Skip to content

Commit 82fca05

Browse files
committed
fix(scaffold-module): address review feedback from tiagoek
- Remove SAP-internal Artifactory URL from user-guide.md template; replace with plain `uv add sap-cloud-sdk` - Remove incorrect token_url derivation from service URL; BTP binding schemas vary and the UAA URL must be read from the binding, not guessed from the service URL - Expand Phase 5 self-review to run the full local gate: ruff check, ruff format --check, ty check, and pytest (not just ruff check)
1 parent 60e759d commit 82fca05

1 file changed

Lines changed: 10 additions & 3 deletions

File tree

.claude/skills/scaffold-module/SKILL.md

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -193,11 +193,15 @@ class BindingData:
193193

194194
def to_config(self) -> <SHORT>Config:
195195
"""Transform raw binding into a unified <SHORT>Config."""
196+
# TODO: BTP service bindings vary — check the actual binding schema.
197+
# Some services provide a separate UAA URL (e.g. binding["uaa"]["url"]);
198+
# others include it as a top-level "url" field. Do not derive token_url
199+
# from the service URL; read it from the binding instead.
196200
return <SHORT>Config(
197201
url=self.url,
198202
client_id=self.clientid,
199203
client_secret=self.clientsecret,
200-
token_url=self.url.rstrip("/") + "/oauth/token",
204+
token_url="", # TODO: populate from the correct binding field
201205
)
202206

203207

@@ -314,7 +318,7 @@ requires:
314318
## Installation
315319
316320
```bash
317-
uv add sap-cloud-sdk --index-url "https://int.repositories.cloud.sap/artifactory/api/pypi/proxy-3rd-party-pypi/simple"
321+
uv add sap-cloud-sdk
318322
```
319323

320324
## Quick Start
@@ -430,9 +434,12 @@ Check the generated files against these criteria. Fix any issues found before re
430434

431435
**D2: Public API hygiene**: verify `__all__` in `__init__.py` contains exactly the public symbols and nothing internal.
432436

433-
Run lint to verify the generated files are clean:
437+
Run the full local quality gate on the generated files:
434438
```bash
435439
uv run ruff check src/sap_cloud_sdk/<MODULE_NAME>/
440+
uv run ruff format --check src/sap_cloud_sdk/<MODULE_NAME>/
441+
uv run ty check src/sap_cloud_sdk/<MODULE_NAME>/
442+
uv run pytest tests/<MODULE_NAME>/ -v
436443
```
437444

438445
Fix any reported issues before proceeding.

0 commit comments

Comments
 (0)