Commit 82fca05
committed
fix(scaffold-module): address review feedback from tiagoek
- Remove SAP-internal Artifactory URL from user-guide.md template;
replace with plain `uv add sap-cloud-sdk`
- Remove incorrect token_url derivation from service URL; BTP binding
schemas vary and the UAA URL must be read from the binding, not
guessed from the service URL
- Expand Phase 5 self-review to run the full local gate: ruff check,
ruff format --check, ty check, and pytest (not just ruff check)1 parent 60e759d commit 82fca05
1 file changed
Lines changed: 10 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
193 | 193 | | |
194 | 194 | | |
195 | 195 | | |
| 196 | + | |
| 197 | + | |
| 198 | + | |
| 199 | + | |
196 | 200 | | |
197 | 201 | | |
198 | 202 | | |
199 | 203 | | |
200 | | - | |
| 204 | + | |
201 | 205 | | |
202 | 206 | | |
203 | 207 | | |
| |||
314 | 318 | | |
315 | 319 | | |
316 | 320 | | |
317 | | - | |
| 321 | + | |
318 | 322 | | |
319 | 323 | | |
320 | 324 | | |
| |||
430 | 434 | | |
431 | 435 | | |
432 | 436 | | |
433 | | - | |
| 437 | + | |
434 | 438 | | |
435 | 439 | | |
| 440 | + | |
| 441 | + | |
| 442 | + | |
436 | 443 | | |
437 | 444 | | |
438 | 445 | | |
| |||
0 commit comments