test: cover auditlog ng factory error telemetry

Author: tiagoek

CHANGELOG.md

@@ -0,0 +1,10 @@
+# Changelog
+
+## [0.20.2] - 2026-05-26
+
+### Fixed
+
+- Record ALS v3 (`auditlog_ng`) capability telemetry when `AuditClient` is
+  initialized, including direct `AuditClient(config)` construction. The
+  `send()` and `send_json()` APIs remain uninstrumented so the metric continues
+  to represent client initialization rather than audit event volume.

src/sap_cloud_sdk/core/auditlog_ng/__init__.py

@@ -104,13 +104,6 @@ def create_client(
                     compression=compression,
                     schema_url=schema_url,
                 )
-            except (ValueError, ValidationError):
-                record_error_metric(
-                    Module.AUDITLOG_NG,
-                    _telemetry_source,
-                    Operation.AUDITLOG_CREATE_CLIENT,
-                )
-                raise
             except Exception:
                 record_error_metric(
                     Module.AUDITLOG_NG,

tests/core/unit/auditlog_ng/unit/test_create_client.py

@@ -49,18 +49,34 @@ def test_create_client_missing_endpoint_raises(self):
         with pytest.raises(ValueError, match="endpoint, deployment_id, and namespace are required"):
             create_client(deployment_id="dep-1", namespace="ns-1")
 
-    def test_create_client_missing_endpoint_records_error_metric(self):
+    @pytest.mark.parametrize(
+        ("kwargs", "match"),
+        [
+            (
+                {"deployment_id": "dep-1", "namespace": "ns-1"},
+                "endpoint, deployment_id, and namespace are required",
+            ),
+            (
+                {
+                    "endpoint": "localhost:4317",
+                    "deployment_id": "bad value",
+                    "namespace": "ns-1",
+                },
+                "deployment_id",
+            ),
+        ],
+    )
+    def test_create_client_config_errors_record_error_metric(self, kwargs, match):
         with patch(
             "sap_cloud_sdk.core.auditlog_ng.record_error_metric"
         ) as mock_error_metric:
             with pytest.raises(
                 ValueError,
-                match="endpoint, deployment_id, and namespace are required",
+                match=match,
             ):
                 create_client(
-                    deployment_id="dep-1",
-                    namespace="ns-1",
                     _telemetry_source=Module.DMS,
+                    **kwargs,
                 )
 
         mock_error_metric.assert_called_once_with(
@@ -96,13 +112,30 @@ def test_create_client_unexpected_exception_wraps_in_client_creation_error(
     ):
         mock_provider_cls.side_effect = RuntimeError("Unexpected failure")
 
-        with pytest.raises(ClientCreationError, match="Failed to create audit log NG client"):
-            create_client(
-                endpoint="localhost:4317",
-                deployment_id="dep-1",
-                namespace="ns-1",
-                insecure=True,
+        with patch(
+            "sap_cloud_sdk.core.telemetry.metrics_decorator.record_error_metric"
+        ) as mock_error_metric:
+            with patch(
+                "sap_cloud_sdk.core.telemetry.metrics_decorator.record_request_metric"
+            ) as mock_request_metric:
+                with pytest.raises(
+                    ClientCreationError, match="Failed to create audit log NG client"
+                ):
+                    create_client(
+                        endpoint="localhost:4317",
+                        deployment_id="dep-1",
+                        namespace="ns-1",
+                        insecure=True,
+                        _telemetry_source=Module.DMS,
+                    )
+
+        mock_error_metric.assert_called_once_with(
+            Module.AUDITLOG_NG,
+            Module.DMS,
+            Operation.AUDITLOG_CREATE_CLIENT,
+            False,
             )
+        mock_request_metric.assert_not_called()
 
     @patch("sap_cloud_sdk.core.auditlog_ng.client._create_log_exporter")
     @patch("sap_cloud_sdk.core.auditlog_ng.client.LoggerProvider")