Skip to content

Commit dcadcf6

Browse files
committed
[FEAT] Operator: AppId handling enhanced
Further changes to replace `globalAccountId` with `providerSubaccountId`. - Deprecate `globalAccountId` and make it optional (TODO: Check if either of `globalAccountId` or `providerSubaccountId` is specified. - Generate new appId based labels/annotations.
1 parent b4b304c commit dcadcf6

3 files changed

Lines changed: 12 additions & 13 deletions

File tree

crds/sme.sap.com_capapplications.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -117,7 +117,6 @@ spec:
117117
required:
118118
- btp
119119
- btpAppName
120-
- globalAccountId
121120
type: object
122121
status:
123122
properties:

pkg/apis/sme.sap.com/v1alpha1/types.go

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -87,16 +87,16 @@ type CAPApplicationList struct {
8787

8888
// CAPApplicationSpec defines the desired state of CAPApplication
8989
type CAPApplicationSpec struct {
90-
// Domains used by the application (new)
90+
// Reference to `Domain` resources used by the application
9191
DomainRefs []DomainRef `json:"domainRefs,omitempty"`
92-
// [DEPRECATED] Domains used by the application // Will be removed in future versions
92+
// Deprecated: Domains used by the application. Will be removed in future versions, use `DomainRefs` instead
9393
Domains ApplicationDomains `json:"domains,omitempty"`
94-
// SAP BTP Global Account Identifier where services are entitles for the current application
95-
// Will soon be deprecated, use ProviderSubaccountId instead
96-
GlobalAccountId string `json:"globalAccountId"`
97-
// The subaccount ID in which the application is provided (will soon replace GlobalAccountId)
94+
// Deprecated: SAP BTP Global Account Identifier where services are entitled for the current application
95+
// Will be removed in future versions, use `ProviderSubaccountId` instead
96+
GlobalAccountId string `json:"globalAccountId,omitempty"`
97+
// The subaccount ID in which the application is provided (will soon replace `GlobalAccountId``)
9898
ProviderSubaccountId string `json:"providerSubaccountId,omitempty"`
99-
// Short name for the application (similar to BTP XSAPPNAME)
99+
// Short name for the application (BTP XSAPPNAME)
100100
BTPAppName string `json:"btpAppName"`
101101
// Provider subaccount where application services are created
102102
Provider *BTPTenantIdentification `json:"provider,omitempty"`

pkg/client/applyconfiguration/sme.sap.com/v1alpha1/capapplicationspec.go

Lines changed: 5 additions & 5 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)