From 76b617ad4c5fd0dec17ae9ab86dbee5e3345cb5a Mon Sep 17 00:00:00 2001 From: Andreas Stange Date: Thu, 19 Aug 2021 14:22:40 +0200 Subject: [PATCH 1/2] show exceptions in acs.jsp and sls.jsp --- .../src/main/webapp/acs.jsp | 23 +++++++++++++--- .../src/main/webapp/sls.jsp | 27 +++++++++++++++---- 2 files changed, 42 insertions(+), 8 deletions(-) diff --git a/samples/java-saml-tookit-jspsample/src/main/webapp/acs.jsp b/samples/java-saml-tookit-jspsample/src/main/webapp/acs.jsp index 99d640d8..5456f9aa 100644 --- a/samples/java-saml-tookit-jspsample/src/main/webapp/acs.jsp +++ b/samples/java-saml-tookit-jspsample/src/main/webapp/acs.jsp @@ -4,7 +4,9 @@ <%@page import="java.util.List"%> <%@page import="java.util.Map"%> <%@page import="org.apache.commons.lang3.StringUtils" %> -<%@ page language="java" contentType="text/html; charset=UTF-8" +<%@page import="java.io.StringWriter"%> +<%@page import="java.io.PrintWriter"%> +<%@page language="java" contentType="text/html; charset=UTF-8" pageEncoding="UTF-8"%> @@ -29,8 +31,23 @@ <% - Auth auth = new Auth(request, response); - auth.processResponse(); + Auth auth; + try + { + auth = new Auth(request, response); + auth.processResponse(); + } + catch (Exception e) + { + e.printStackTrace(); + + StringWriter sw = new StringWriter(); + PrintWriter pw = new PrintWriter(sw); + e.printStackTrace(pw); + String stackTrace = sw.toString().replace("\n", "
"); + out.println("
" + stackTrace + "
"); + return; + } if (!auth.isAuthenticated()) { out.println("
Not authenticated
"); diff --git a/samples/java-saml-tookit-jspsample/src/main/webapp/sls.jsp b/samples/java-saml-tookit-jspsample/src/main/webapp/sls.jsp index bf80405c..97b31637 100644 --- a/samples/java-saml-tookit-jspsample/src/main/webapp/sls.jsp +++ b/samples/java-saml-tookit-jspsample/src/main/webapp/sls.jsp @@ -2,8 +2,10 @@ <%@page import="java.util.Collection"%> <%@page import="java.util.HashMap"%> <%@page import="java.util.List"%> -<%@page import="java.util.Map"%> -<%@ page language="java" contentType="text/html; charset=UTF-8" +<%@page import="java.util.Map"%> +<%@page import="java.io.StringWriter"%> +<%@page import="java.io.PrintWriter"%> +<%@page language="java" contentType="text/html; charset=UTF-8" pageEncoding="UTF-8"%> @@ -26,9 +28,24 @@

A Java SAML Toolkit by OneLogin demo

Logout <% - Auth auth = new Auth(request, response); - auth.processSLO(); - + Auth auth; + try + { + auth = new Auth(request, response); + auth.processSLO(); + } + catch (Exception e) + { + e.printStackTrace(); + + StringWriter sw = new StringWriter(); + PrintWriter pw = new PrintWriter(sw); + e.printStackTrace(pw); + String stackTrace = sw.toString().replace("\n", "
"); + out.println("
" + stackTrace + "
"); + return; + } + List errors = auth.getErrors(); if (errors.isEmpty()) { From 87f1b214edebf8931811e378ab22dcc33e5ca41e Mon Sep 17 00:00:00 2001 From: Andreas Stange Date: Thu, 19 Aug 2021 14:23:24 +0200 Subject: [PATCH 2/2] fix indent in metadata.jsp --- samples/java-saml-tookit-jspsample/src/main/webapp/metadata.jsp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/samples/java-saml-tookit-jspsample/src/main/webapp/metadata.jsp b/samples/java-saml-tookit-jspsample/src/main/webapp/metadata.jsp index 1b2388e0..0d8ff043 100644 --- a/samples/java-saml-tookit-jspsample/src/main/webapp/metadata.jsp +++ b/samples/java-saml-tookit-jspsample/src/main/webapp/metadata.jsp @@ -5,7 +5,7 @@ settings.setSPValidationOnly(true); List errors = settings.checkSettings(); if (errors.isEmpty()) { - String metadata = settings.getSPMetadata(); + String metadata = settings.getSPMetadata(); out.println(metadata); } else { response.setContentType("text/html; charset=UTF-8");