Multi-row inserts are now supported.

Author: RyanLamansky

SqlServerSimulator.Tests.EFCore/EFCoreBasics.cs

@@ -13,7 +13,7 @@ public static async Task HotPath(TestContext context)
 
         // Triggers JIT compilation of the most common path among all tests, improving the accuracy of their timings.
         // Also functions as a sanity check against the simulator being completely broken.
-        using var dbContext = new TestDbContext(1);
+        using var dbContext = new TestDbContext(1, 2);
         _ = await dbContext.Rows.Select(x => x.Id).FirstOrDefaultAsync(context.CancellationToken);
     }
 
@@ -32,8 +32,8 @@ public static Simulation CreateDefaultSimulation(params ReadOnlySpan<int> values
             {
                 var row = new TestRow { Id = value };
                 _ = context.Rows.Add(row);
-                _ = context.SaveChanges();
             }
+            _ = context.SaveChanges();
         }
 
         return simulation;
@@ -94,7 +94,7 @@ public void RoundTrip()
     }
 
     [TestMethod]
-    public void SeparateInserts()
+    public void MultiRowInsert()
     {
         int[] storedValues = [2, 3];
         using var context = new TestDbContext(storedValues);
@@ -114,10 +114,9 @@ public void FirstOrDefault()
     [TestMethod]
     public void SingleOrDefault()
     {
-        const int storedValue = 6;
+        const int storedValue = 6; // Until `Where` is supported, this won't pass if multiple rows exist.
         using var context = new TestDbContext(storedValue);
         var receivedValue = context.Rows.Select(x => x.Id);
-        // Without an OrderBy, we can't guarantee which of the two possibilities is returned.
         Assert.AreEqual(storedValue, receivedValue.SingleOrDefault());
     }
 

SqlServerSimulator.Tests/InsertTests.cs

@@ -13,15 +13,21 @@ public class InsertTests
     );
 
     [TestMethod]
-    [DataRow("create table t ( v int );insert t values ( 1 )", 1)]
-    [DataRow("create table t ( v int );insert T values ( 1 )", 1)]
-    [DataRow("create table t ( v int );insert t ( v ) values ( 1 )", 1)]
-    [DataRow("create table t ( v int );insert t ( V ) values ( 1 )", 1)]
+    [DataRow("t values ( 1 )", 1)]
+    [DataRow("T values ( 1 )", 1)]
+    [DataRow("t ( v ) values ( 1 )", 1)]
+    [DataRow("t ( V ) values ( 1 )", 1)]
+    [DataRow("t values ( 1 ), ( 2 )", 2)]
     public void Insert(string commandText, int expectedRecordsAffected)
     {
-        var result = new Simulation()
+        var simulation = new Simulation();
+        _ = simulation
             .CreateOpenConnection()
-            .CreateCommand(commandText)
+            .CreateCommand("create table t ( v int )")
+            .ExecuteNonQuery();
+
+        var result = simulation
+            .CreateCommand($"insert {commandText}")
             .ExecuteNonQuery();
 
         Assert.AreEqual(expectedRecordsAffected, result);

SqlServerSimulator/Simulation.cs

@@ -175,21 +175,24 @@ internal IEnumerable<SimulatedStatementOutcome> CreateResultSetsForCommand(Simul
                             if (context.Token is not ReservedKeyword { Keyword: Keyword.Values })
                                 break;
 
-                            if (context.GetNextRequired() is not Operator { Character: '(' })
-                                break;
+                            var sourceRows = new List<Token[]>();
 
-                            var sourceValues = new List<Token>();
-                            while (context.GetNextRequired() is not Operator { Character: ')' })
+                            do
                             {
-                                sourceValues.Add(context.Token);
-                            }
+                                if (context.GetNextRequired<Operator>() is not { Character: '(' })
+                                    throw SimulatedSqlException.SyntaxErrorNear(context.Token);
+
+                                var sourceValues = new List<Token>();
+                                while (context.GetNextRequired() is not Operator { Character: ')' })
+                                    sourceValues.Add(context.Token);
+
+                                sourceRows.Add([.. sourceValues]);
 
-                            if (context.Token is not Operator { Character: ')' })
-                                throw new NotSupportedException("Simulated command processor expected a closing parentheses.");
+                            } while (context.GetNextOptional() is Operator { Character: ',' });
 
-                            destinationTable.ReceiveData(destinationColumns, [[.. sourceValues]], context.GetVariableValue);
+                            destinationTable.ReceiveData(destinationColumns, sourceRows, context.GetVariableValue);
 
-                            yield return new SimulatedNonQuery(sourceValues.Count);
+                            yield return new SimulatedNonQuery(sourceRows.Count);
                             continue;
                     }
                     break;