selftests/tcp_ao: Zero-init tcp_ao_info_opt

0x7f454c46 · Paolo Abeni · commit b089b3bead53 · 2024-04-16T13:35:05.000+02:00
The structure is on the stack and has to be zero-initialized as the kernel checks for: > if (in.reserved != 0 || in.reserved2 != 0) > return -EINVAL; Fixes: b266605 ("selftests/net: Add test for TCP-AO add setsockopt() command") Signed-off-by: Dmitry Safonov <0x7f454c46@gmail.com> Signed-off-by: Paolo Abeni <pabeni@redhat.com>
diff --git a/tools/testing/selftests/net/tcp_ao/setsockopt-closed.c b/tools/testing/selftests/net/tcp_ao/setsockopt-closed.c
@@ -21,7 +21,7 @@ static void make_listen(int sk)
 static void test_vefify_ao_info(int sk, struct tcp_ao_info_opt *info,
 				const char *tst)
 {
-	struct tcp_ao_info_opt tmp;
+	struct tcp_ao_info_opt tmp = {};
 	socklen_t len = sizeof(tmp);
 
 	if (getsockopt(sk, IPPROTO_TCP, TCP_AO_INFO, &tmp, &len))

Original file line number	Diff line number	Diff line change
`@@ -21,7 +21,7 @@ static void make_listen(int sk)`
`21`	`21`	`static void test_vefify_ao_info(int sk, struct tcp_ao_info_opt *info,`
`22`	`22`	`const char *tst)`
`23`	`23`	`{`
`24`		`- struct tcp_ao_info_opt tmp;`
	`24`	`+ struct tcp_ao_info_opt tmp = {};`
`25`	`25`	`socklen_t len = sizeof(tmp);`
`26`	`26`
`27`	`27`	`if (getsockopt(sk, IPPROTO_TCP, TCP_AO_INFO, &tmp, &len))`