Skip to content

Commit 71e3863

Browse files
committed
Merge remote-tracking branch 'origin/bugfix/settings-navigation' into release/v2.2.1
2 parents e63213a + 726105e commit 71e3863

5 files changed

Lines changed: 45 additions & 12 deletions

File tree

app/src/main/AndroidManifest.xml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -159,6 +159,9 @@
159159
<activity
160160
android:name=".presentation.mypage.upload.MyUploadActivity"
161161
android:exported="false" />
162+
<activity
163+
android:name=".presentation.mypage.setting.MySettingActivity"
164+
android:exported="false" />
162165
<activity
163166
android:name=".presentation.profile.ProfileActivity"
164167
android:exported="false" />

app/src/main/java/com/runnect/runnect/presentation/mypage/MyPageFragment.kt

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,6 @@ import androidx.compose.ui.platform.ComposeView
1414
import androidx.compose.ui.platform.ViewCompositionStrategy
1515
import androidx.fragment.app.Fragment
1616
import androidx.fragment.app.activityViewModels
17-
import androidx.fragment.app.commit
18-
import androidx.fragment.app.replace
1917
import com.kakao.sdk.common.util.KakaoCustomTabsClient
2018
import com.kakao.sdk.talk.TalkApiClient
2119
import com.runnect.runnect.BuildConfig
@@ -25,7 +23,7 @@ import com.runnect.runnect.presentation.login.LoginActivity
2523
import com.runnect.runnect.presentation.mypage.editname.MyPageEditNameActivity
2624
import com.runnect.runnect.presentation.mypage.history.MyHistoryActivity
2725
import com.runnect.runnect.presentation.mypage.reward.MyRewardActivity
28-
import com.runnect.runnect.presentation.mypage.setting.MySettingFragment
26+
import com.runnect.runnect.presentation.mypage.setting.MySettingActivity
2927
import com.runnect.runnect.presentation.mypage.upload.MyUploadActivity
3028
import com.runnect.runnect.presentation.ui.theme.RunnectTheme
3129
import com.runnect.runnect.util.analytics.Analytics
@@ -122,11 +120,11 @@ class MyPageFragment : Fragment() {
122120
}
123121

124122
private fun moveToSettingFragment() {
125-
val bundle = Bundle().apply { putString(ACCOUNT_INFO_TAG, viewModel.currentState.email) }
126-
requireActivity().supportFragmentManager.commit {
127-
setCustomAnimations(R.anim.slide_in_right, R.anim.slide_out_left)
128-
replace<MySettingFragment>(R.id.fl_main, args = bundle)
123+
val intent = Intent(requireContext(), MySettingActivity::class.java).apply {
124+
putExtra(ACCOUNT_INFO_TAG, viewModel.currentState.email)
129125
}
126+
startActivity(intent)
127+
requireActivity().overridePendingTransition(R.anim.slide_in_right, R.anim.slide_out_left)
130128
}
131129

132130
private fun inquiryKakao() {
Lines changed: 29 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,29 @@
1+
package com.runnect.runnect.presentation.mypage.setting
2+
3+
import android.os.Bundle
4+
import androidx.appcompat.app.AppCompatActivity
5+
import androidx.fragment.app.commit
6+
import androidx.fragment.app.replace
7+
import com.runnect.runnect.R
8+
import dagger.hilt.android.AndroidEntryPoint
9+
10+
@AndroidEntryPoint
11+
class MySettingActivity : AppCompatActivity() {
12+
13+
override fun onCreate(savedInstanceState: Bundle?) {
14+
super.onCreate(savedInstanceState)
15+
setContentView(R.layout.activity_my_setting)
16+
17+
if (savedInstanceState == null) {
18+
val bundle = Bundle().apply {
19+
putString(
20+
MySettingFragment.ACCOUNT_INFO_TAG,
21+
intent.getStringExtra(MySettingFragment.ACCOUNT_INFO_TAG)
22+
)
23+
}
24+
supportFragmentManager.commit {
25+
replace<MySettingFragment>(R.id.fl_main, args = bundle)
26+
}
27+
}
28+
}
29+
}

app/src/main/java/com/runnect/runnect/presentation/mypage/setting/MySettingFragment.kt

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@ import com.runnect.runnect.BuildConfig
1212
import com.runnect.runnect.R
1313
import com.runnect.runnect.binding.BindingFragment
1414
import com.runnect.runnect.databinding.FragmentMySettingBinding
15-
import com.runnect.runnect.presentation.mypage.MyPageFragment
1615
import com.runnect.runnect.presentation.mypage.setting.accountinfo.MySettingAccountInfoFragment
1716
import com.runnect.runnect.util.extension.showWebBrowser
1817

@@ -57,10 +56,8 @@ class MySettingFragment : BindingFragment<FragmentMySettingBinding>(R.layout.fra
5756
}
5857

5958
private fun navigateToMyPageFragment() {
60-
parentFragmentManager.commit {
61-
setCustomAnimations(R.anim.slide_in_left, R.anim.slide_out_right)
62-
replace<MyPageFragment>(R.id.fl_main)
63-
}
59+
requireActivity().finish()
60+
requireActivity().overridePendingTransition(R.anim.slide_in_left, R.anim.slide_out_right)
6461
}
6562

6663
private fun moveToMySettingAccountInfo() {
Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
<?xml version="1.0" encoding="utf-8"?>
2+
<FrameLayout xmlns:android="http://schemas.android.com/apk/res/android"
3+
android:id="@+id/fl_main"
4+
android:layout_width="match_parent"
5+
android:layout_height="match_parent"
6+
android:fitsSystemWindows="true" />

0 commit comments

Comments
 (0)