From e937fc37e551641c2711bf177a743d5489d9c071 Mon Sep 17 00:00:00 2001 From: Martin Burchell Date: Fri, 7 Mar 2025 06:55:55 +0000 Subject: [PATCH 1/3] Reinstate BIT and friends as valid datatypes --- cardinal_pythonlib/sql/validation.py | 1 + 1 file changed, 1 insertion(+) diff --git a/cardinal_pythonlib/sql/validation.py b/cardinal_pythonlib/sql/validation.py index 1fb040d..898f940 100644 --- a/cardinal_pythonlib/sql/validation.py +++ b/cardinal_pythonlib/sql/validation.py @@ -212,6 +212,7 @@ SQLTYPES_ALL = ( SQLTYPES_INTEGER + SQLTYPES_FLOAT + + SQLTYPES_BIT + SQLTYPES_OTHER_NUMERIC + SQLTYPES_TEXT + SQLTYPES_BINARY From 3e7910b9eff560198601defe5b59243ea20b1de4 Mon Sep 17 00:00:00 2001 From: Martin Burchell Date: Sat, 8 Mar 2025 07:07:07 +0000 Subject: [PATCH 2/3] Also add BIT to SQLTYPES_NOT_TEXT and SQLTYPES_NUMERIC --- cardinal_pythonlib/sql/validation.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/cardinal_pythonlib/sql/validation.py b/cardinal_pythonlib/sql/validation.py index 898f940..ec32948 100644 --- a/cardinal_pythonlib/sql/validation.py +++ b/cardinal_pythonlib/sql/validation.py @@ -222,11 +222,14 @@ SQLTYPES_NOT_TEXT = ( SQLTYPES_INTEGER + SQLTYPES_FLOAT + + SQLTYPES_BIT + SQLTYPES_OTHER_NUMERIC + SQLTYPES_DATETIME_ALL + SQLTYPES_OTHER ) -SQLTYPES_NUMERIC = SQLTYPES_INTEGER + SQLTYPES_FLOAT + SQLTYPES_OTHER_NUMERIC +SQLTYPES_NUMERIC = ( + SQLTYPES_INTEGER + SQLTYPES_FLOAT + SQLTYPES_BIT + SQLTYPES_OTHER_NUMERIC +) # ============================================================================= From acb839e59ccd2fbe303bf1dff0290e302f8e044c Mon Sep 17 00:00:00 2001 From: Martin Burchell Date: Sat, 8 Mar 2025 11:27:27 +0000 Subject: [PATCH 3/3] Update changelog --- docs/source/changelog.rst | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/docs/source/changelog.rst b/docs/source/changelog.rst index 95b4621..aa20d24 100644 --- a/docs/source/changelog.rst +++ b/docs/source/changelog.rst @@ -33,6 +33,7 @@ Quick links: - :ref:`2022 ` - :ref:`2023 ` - :ref:`2024 ` +- :ref:`2025 ` .. _changelog_2017: @@ -853,7 +854,7 @@ Quick links: were executing unconditionally, regardless of SQLAlchemy dialect (they should have been conditional to SQL Server). -**2.0.2** +**2.0.2 (2025-03-06)** - Bugfix to :func:`cardinal_pythonlib.sqlalchemy.alembic_func.get_current_revision` where @@ -871,3 +872,8 @@ Quick links: default table dependency order and calculate another. - Improve ability of Alembic support code to take a database URL. + +**2.0.3** + +- Reinstate BIT and similar datatypes in the list of valid datatypes. Broken + since v2.0.0.