From dd2e51e40333553a56091d7a90cc8cadf6b14cc4 Mon Sep 17 00:00:00 2001 From: Simone Albanesi Date: Sat, 7 Feb 2026 01:58:58 +0100 Subject: [PATCH 1/4] minor in coordchange --- PyART/analytic/coordschange.py | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/PyART/analytic/coordschange.py b/PyART/analytic/coordschange.py index deafbbb..3349dde 100644 --- a/PyART/analytic/coordschange.py +++ b/PyART/analytic/coordschange.py @@ -308,6 +308,8 @@ def eob_ID_to_ADM(eob_Wave, verbose=False, PN_order=2, rotate_on_x_axis=True): x2 = -d_ADM * q / (q + 1) x_offset = -b_par + d_ADM / (q + 1) + qe_check, pe_check = Adm2Eob(qa, pa, nu, PN_order=PN_order) + # wrap output out = { "q_cart": qa, @@ -318,12 +320,11 @@ def eob_ID_to_ADM(eob_Wave, verbose=False, PN_order=2, rotate_on_x_axis=True): "x2": x2, "D": d_ADM, "x_offset": x_offset, + "qe_check":qe_check, + "pe_check":pe_check } if verbose: - # for testing - qe_check, pe_check = Adm2Eob(qa, pa, nu, PN_order=PN_order) - dashes = "-" * 50 print("{}\nPunctures\n{}".format(dashes, dashes)) print("b_par : {:.15f}".format(b_par)) From 7b3af00a6191e0291ac32463d0d84452f9ff8649 Mon Sep 17 00:00:00 2001 From: "pre-commit-ci[bot]" <66853113+pre-commit-ci[bot]@users.noreply.github.com> Date: Sat, 7 Feb 2026 01:05:15 +0000 Subject: [PATCH 2/4] [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --- PyART/analytic/coordschange.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/PyART/analytic/coordschange.py b/PyART/analytic/coordschange.py index 3349dde..f9eb1ca 100644 --- a/PyART/analytic/coordschange.py +++ b/PyART/analytic/coordschange.py @@ -309,7 +309,7 @@ def eob_ID_to_ADM(eob_Wave, verbose=False, PN_order=2, rotate_on_x_axis=True): x_offset = -b_par + d_ADM / (q + 1) qe_check, pe_check = Adm2Eob(qa, pa, nu, PN_order=PN_order) - + # wrap output out = { "q_cart": qa, @@ -320,8 +320,8 @@ def eob_ID_to_ADM(eob_Wave, verbose=False, PN_order=2, rotate_on_x_axis=True): "x2": x2, "D": d_ADM, "x_offset": x_offset, - "qe_check":qe_check, - "pe_check":pe_check + "qe_check": qe_check, + "pe_check": pe_check, } if verbose: From 23482f186c506348b85c5a0671d134e82d3305bf Mon Sep 17 00:00:00 2001 From: Simone Albanesi Date: Sat, 7 Feb 2026 02:41:50 +0100 Subject: [PATCH 3/4] added also pe in output --- PyART/analytic/coordschange.py | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/PyART/analytic/coordschange.py b/PyART/analytic/coordschange.py index f9eb1ca..bee60c1 100644 --- a/PyART/analytic/coordschange.py +++ b/PyART/analytic/coordschange.py @@ -271,6 +271,10 @@ def eob_ID_to_ADM(eob_Wave, verbose=False, PN_order=2, rotate_on_x_axis=True): 'x2' : x coordinate of puncture 2 'D' : coordinate separation between punctures 'x_offset' : offset to be added to x coordinates + 'qe' : EOB coordinates (x,y) + 'pe' : EOB momenta (px, py), mu-normalized + 'qe_chk' : EOB coordinates (x,y), EOB->ADM->EOB + 'pe_chk' : EOB momenta (px, py), mu-normalized, EOB->ADM->EOB """ # Get info from EOB dynamics q = eob_Wave.pars["q"] @@ -320,8 +324,10 @@ def eob_ID_to_ADM(eob_Wave, verbose=False, PN_order=2, rotate_on_x_axis=True): "x2": x2, "D": d_ADM, "x_offset": x_offset, - "qe_check": qe_check, - "pe_check": pe_check, + "qe": qe, + "pe": pe, + "qe_chk": qe_check, # EOB->ADM->EOB + "pe_chk": pe_check, # EOB->ADM->EOB } if verbose: From edf4605db970a2eaf68d04cb14343ac97e7b0a3f Mon Sep 17 00:00:00 2001 From: "pre-commit-ci[bot]" <66853113+pre-commit-ci[bot]@users.noreply.github.com> Date: Sat, 7 Feb 2026 01:42:07 +0000 Subject: [PATCH 4/4] [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --- PyART/analytic/coordschange.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/PyART/analytic/coordschange.py b/PyART/analytic/coordschange.py index bee60c1..6ea9b3a 100644 --- a/PyART/analytic/coordschange.py +++ b/PyART/analytic/coordschange.py @@ -325,9 +325,9 @@ def eob_ID_to_ADM(eob_Wave, verbose=False, PN_order=2, rotate_on_x_axis=True): "D": d_ADM, "x_offset": x_offset, "qe": qe, - "pe": pe, - "qe_chk": qe_check, # EOB->ADM->EOB - "pe_chk": pe_check, # EOB->ADM->EOB + "pe": pe, + "qe_chk": qe_check, # EOB->ADM->EOB + "pe_chk": pe_check, # EOB->ADM->EOB } if verbose: