Merge branch 'develop' into fix/setup-wizard-back-navigation

Author: Subhooo5

.changeset/calm-weeks-mate.md

@@ -0,0 +1,6 @@
+---
+'@rocket.chat/apps-engine': minor
+'@rocket.chat/meteor': minor
+---
+
+Adds file metadata to the Apps.Engine for messages with multiple files

.changeset/eighty-windows-join.md

@@ -0,0 +1,5 @@
+---
+"@rocket.chat/meteor": patch
+---
+
+Fixes an issue where the Resend Verification Email could be abused to spam mail servers

.changeset/fix-dwg-file-preview.md

@@ -0,0 +1,5 @@
+---
+'@rocket.chat/meteor': patch
+---
+
+Fixes preview generation for vendor-specific image formats like `.dwg` (AutoCAD) files. Files with MIME types such as `image/vnd.dwg` and `image/vnd.microsoft.icon` are now excluded from preview generation as they cannot be processed by the Sharp image library, preventing failed preview attempts.

.changeset/fix-readonly-channel-video-calls.md

@@ -0,0 +1,5 @@
+---
+'@rocket.chat/meteor': patch
+---
+
+Fixes an issue where regular users could start video conference calls in read-only channels bypassing message restrictions

.changeset/hip-melons-bow.md

@@ -0,0 +1,5 @@
+---
+'@rocket.chat/meteor': patch
+---
+
+Limits `Outgoing webhook` maximum response size to 10mb.

.changeset/shiny-pears-admire.md

@@ -0,0 +1,5 @@
+---
+"@rocket.chat/meteor": patch
+---
+
+Fixes an issue where `Production` flag was not being respected when initializing Push Notifications configuration

.changeset/tame-humans-greet.md

@@ -27,6 +27,14 @@ inputs:
     description: 'Platform architecture to compare (amd64 or arm64)'
     required: false
     default: 'amd64'
+  size-thresholds:
+    description: 'Optional JSON: per-image trigger thresholds. Only comment when an image increase exceeds its threshold. Example: {"rocketchat":{"mb":50,"percent":5},"omnichannel":{"mb":10,"percent":2}}'
+    required: false
+    default: ''
+  fail-thresholds:
+    description: 'Optional JSON: per-image fail thresholds. Task fails when an image increase exceeds its threshold (mb and/or percent). Example: {"rocketchat":{"mb":100,"percent":15}}'
+    required: false
+    default: ''
 
 outputs:
   total-size:
@@ -38,6 +46,12 @@ outputs:
   size-diff-percent:
     description: 'Size difference percentage'
     value: ${{ steps.compare.outputs.size-diff-percent }}
+  comment-triggered:
+    description: 'Whether to post PR comment (only when size is bigger and thresholds met)'
+    value: ${{ steps.compare.outputs.comment-triggered }}
+  failed:
+    description: 'True if image size exceeded fail-thresholds'
+    value: ${{ steps.compare.outputs.failed }}
 
 runs:
   using: 'composite'
@@ -52,8 +66,10 @@ runs:
     - name: Measure image sizes from artifacts
       id: measure
       shell: bash
+      env:
+        PLATFORM: ${{ inputs.platform }}
+        TAG: ${{ inputs.tag }}
       run: |
-        PLATFORM="${{ inputs.platform }}"
         echo "Reading image sizes from build artifacts for platform: $PLATFORM"
 
         declare -A sizes
@@ -94,7 +110,7 @@ runs:
         # Save to JSON
         echo "{" > current-sizes.json
         echo "  \"timestamp\": \"$(date -u +%Y-%m-%dT%H:%M:%SZ)\"," >> current-sizes.json
-        echo "  \"tag\": \"${{ inputs.tag }}\"," >> current-sizes.json
+        echo "  \"tag\": \"$TAG\"," >> current-sizes.json
         echo "  \"total\": $total," >> current-sizes.json
         echo "  \"services\": {" >> current-sizes.json
 
@@ -121,12 +137,12 @@ runs:
       id: baseline
       shell: bash
       continue-on-error: true
+      env:
+        REGISTRY: ${{ inputs.registry }}
+        ORG: ${{ inputs.repository }}
+        TAG: ${{ inputs.baseline-tag }}
+        PLATFORM: ${{ inputs.platform }}
       run: |
-        REGISTRY="${{ inputs.registry }}"
-        ORG="${{ inputs.repository }}"
-        TAG="${{ inputs.baseline-tag }}"
-        PLATFORM="${{ inputs.platform }}"
-
         echo "Measuring baseline: $REGISTRY/$ORG/*:$TAG (platform: $PLATFORM)"
 
         declare -A sizes
@@ -251,6 +267,8 @@ runs:
     - name: Save current measurement to history
       if: github.ref == 'refs/heads/develop'
       shell: bash
+      env:
+        CI_PAT: ${{ inputs.ci-pat }}
       run: |
         timestamp=$(date -u +%Y%m%d-%H%M%S)
         commit_sha="${{ github.sha }}"
@@ -263,7 +281,7 @@ runs:
         git commit -m "Add measurement for ${timestamp} (${commit_sha:0:7})"
         git config --global user.email "ci@rocket.chat"
         git config --global user.name "rocketchat-ci[bot]"
-        git config --global url.https://${{ inputs.ci-pat }}@github.com/.insteadOf https://github.com/
+        git config --global url.https://$CI_PAT@github.com/.insteadOf https://github.com/
         git push origin image-size-history
         cd -
 
@@ -272,13 +290,19 @@ runs:
     - name: Compare and generate report
       id: compare
       shell: bash
+      env:
+        SIZE_THRESHOLDS: ${{ inputs.size-thresholds }}
+        FAIL_THRESHOLDS: ${{ inputs.fail-thresholds }}
+        TAG: ${{ inputs.tag }}
+        BASELINE_TAG: ${{ inputs.baseline-tag }}
       run: |
         current_total=$(jq -r '.total' current-sizes.json)
 
         if [[ ! -f baseline-sizes.json ]]; then
           echo "No baseline available"
           echo "size-diff=0" >> $GITHUB_OUTPUT
           echo "size-diff-percent=0" >> $GITHUB_OUTPUT
+          echo "comment-triggered=false" >> $GITHUB_OUTPUT
 
           cat > report.md << 'EOF'
         # 📦 Docker Image Size Report
@@ -302,6 +326,17 @@ runs:
         echo "size-diff=$diff" >> $GITHUB_OUTPUT
         echo "size-diff-percent=$percent" >> $GITHUB_OUTPUT
 
+        # Only comment when size is bigger than baseline; optionally require per-image thresholds
+        THRESHOLDS="$SIZE_THRESHOLDS"
+        FAIL_THRESHOLDS="$FAIL_THRESHOLDS"
+        comment_triggered=false
+        fail_triggered=false
+        if [[ $diff -gt 0 ]]; then
+          if [[ -z "$THRESHOLDS" ]] || [[ "$THRESHOLDS" == "{}" ]]; then
+            comment_triggered=true
+          fi
+        fi
+
         color="gray"
         if (( $(awk "BEGIN {print ($percent > 0.01)}") )); then
           color="red"
@@ -346,6 +381,38 @@ runs:
             service_percent=0
           fi
 
+          # Check per-image thresholds for comment trigger (only when size increased)
+          if [[ $diff -gt 0 ]] && [[ -n "$THRESHOLDS" ]] && [[ "$THRESHOLDS" != "{}" ]]; then
+            threshold_mb=$(echo "$THRESHOLDS" | jq -r ".\"$service\".mb // empty")
+            threshold_pct=$(echo "$THRESHOLDS" | jq -r ".\"$service\".percent // empty")
+            if [[ -n "$threshold_mb" ]] || [[ -n "$threshold_pct" ]]; then
+              exceeded=false
+              if [[ -n "$threshold_mb" ]] && [[ $service_diff -ge $(awk "BEGIN {printf \"%.0f\", $threshold_mb * 1048576}") ]]; then
+                exceeded=true
+              fi
+              if [[ -n "$threshold_pct" ]] && [[ $service_percent != "0.00" ]] && (( $(awk "BEGIN {print ($service_percent >= $threshold_pct)}") )); then
+                exceeded=true
+              fi
+              [[ "$exceeded" == "true" ]] && comment_triggered=true
+            fi
+          fi
+
+          # Check per-image fail thresholds (task fails when exceeded)
+          if [[ $diff -gt 0 ]] && [[ -n "$FAIL_THRESHOLDS" ]] && [[ "$FAIL_THRESHOLDS" != "{}" ]]; then
+            fail_mb=$(echo "$FAIL_THRESHOLDS" | jq -r ".\"$service\".mb // empty")
+            fail_pct=$(echo "$FAIL_THRESHOLDS" | jq -r ".\"$service\".percent // empty")
+            if [[ -n "$fail_mb" ]] || [[ -n "$fail_pct" ]]; then
+              exceeded=false
+              if [[ -n "$fail_mb" ]] && [[ $service_diff -ge $(awk "BEGIN {printf \"%.0f\", $fail_mb * 1048576}") ]]; then
+                exceeded=true
+              fi
+              if [[ -n "$fail_pct" ]] && [[ $service_percent != "0.00" ]] && (( $(awk "BEGIN {print ($service_percent >= $fail_pct)}") )); then
+                exceeded=true
+              fi
+              [[ "$exceeded" == "true" ]] && fail_triggered=true
+            fi
+          fi
+
           color="gray"
           if (( $(awk "BEGIN {print ($service_percent > 0.01)}") )); then
             color="red"
@@ -474,62 +541,31 @@ runs:
         <details>
         <summary>ℹ️ About this report</summary>
 
-        This report compares Docker image sizes from this build against the \`${{ inputs.baseline-tag }}\` baseline.
+        This report compares Docker image sizes from this build against the \`$BASELINE_TAG\` baseline.
 
-        - **Tag:** \`${{ inputs.tag }}\`
-        - **Baseline:** \`${{ inputs.baseline-tag }}\`
+        - **Tag:** \`$TAG\`
+        - **Baseline:** \`$BASELINE_TAG\`
         - **Timestamp:** $(date -u +"%Y-%m-%d %H:%M:%S UTC")
         - **Historical data points:** $history_count
 
         </details>
         EOF
 
-    - name: Comment on PR
-      if: github.event_name == 'pull_request'
-      uses: actions/github-script@v7
-      with:
-        github-token: ${{ inputs.github-token }}
-        script: |
-          const fs = require('fs');
-
-          if (!fs.existsSync('report.md')) {
-            console.log('No report found, skipping comment');
-            return;
-          }
-
-          const report = fs.readFileSync('report.md', 'utf8');
-
-          // Find existing comment
-          const comments = await github.rest.issues.listComments({
-            owner: context.repo.owner,
-            repo: context.repo.repo,
-            issue_number: context.issue.number
-          });
-
-          const botComment = comments.data.find(comment =>
-            comment.user.type === 'Bot' &&
-            comment.body.includes('📦 Docker Image Size Report')
-          );
-
-          const commentBody = report + '\n\n---\n*Updated: ' + new Date().toUTCString() + '*';
-
-          if (botComment) {
-            await github.rest.issues.updateComment({
-              owner: context.repo.owner,
-              repo: context.repo.repo,
-              comment_id: botComment.id,
-              body: commentBody
-            });
-            console.log('Updated existing comment');
-          } else {
-            await github.rest.issues.createComment({
-              owner: context.repo.owner,
-              repo: context.repo.repo,
-              issue_number: context.issue.number,
-              body: commentBody
-            });
-            console.log('Created new comment');
-          }
+        echo "comment-triggered=$comment_triggered" >> $GITHUB_OUTPUT
+        echo "failed=$fail_triggered" >> $GITHUB_OUTPUT
+
+        if [[ "$fail_triggered" == "true" ]]; then
+          echo "::error::Docker image size exceeded fail-thresholds (mb/percent). Check the report for details."
+          exit 1
+        fi
+
+    - name: Add report to Job Summary
+      if: always()
+      shell: bash
+      run: |
+        if [[ -f report.md ]]; then
+          cat report.md >> $GITHUB_STEP_SUMMARY
+        fi
 
     - name: Cleanup worktree
       if: always()

.github/actions/docker-image-size-tracker/action.yml

@@ -458,6 +458,7 @@ jobs:
           repository: ${{ needs.release-versions.outputs.lowercase-repo }}
           tag: ${{ needs.release-versions.outputs.gh-docker-tag }}
           baseline-tag: develop
+          size-thresholds: '{"rocketchat":{"mb":11}}'
 
   checks:
     needs: [release-versions, packages-build]

.github/workflows/ci.yml

@@ -0,0 +1 @@
+Subproject commit e5b749fabc58569dd3d3d059ca1745d9606b661d