feat(extension): v1.0.2 AMO-ready (Firefox submission prep)#5
Open
RipperMercs wants to merge 1 commit into
Open
feat(extension): v1.0.2 AMO-ready (Firefox submission prep)#5RipperMercs wants to merge 1 commit into
RipperMercs wants to merge 1 commit into
Conversation
Three changes to clear AMO (addons.mozilla.org) lint blockers ahead of the Firefox listing: - manifest: add `background.scripts: ["bg.js"]` alongside `service_worker` so Firefox MV3 has a supported entry point (Chrome continues to use the worker; Firefox uses the script — both reference the same bg.js) - manifest: add `gecko.data_collection_permissions.required: ["none"]` — Mozilla now requires this declared even for extensions that collect no user data (popup only fetches the public /api/status/summary) - icons: `icon48.png` was actually 32×32 and `icon128.png` was actually 400×400; both regenerated at their declared sizes from the 400× master, which is preserved as `icon-source-400.png` for future re-renders `web-ext lint` now passes with 0 errors (3 informational warnings about Firefox 140+ keys being ignored on the 121 strict_min_version — non-blocking for AMO). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
extension/manifest.json1.0.1 → 1.0.2background.scripts: ["bg.js"]) alongsideservice_worker— Chrome continues to use the worker, Firefox uses the script, both reference the same filegecko.data_collection_permissions.required: ["none"](Mozilla now requires this declared even when nothing is collected)icon48.png(was 32×32 → now true 48×48) andicon128.png(was 400×400 → now true 128×128); 400× master preserved asicons/icon-source-400.pngfor future re-rendersweb-ext-artifacts/build outputThese three fixes correspond to the only errors+warnings
web-ext lintflagged against AMO rules. After the patch, lint reports 0 errors (3 informational warnings about FF 140+ keys being ignored on the FF 121 strict_min_version — non-blocking).Why 1.0.2 only ships to Firefox
Chrome Web Store accepted 1.0.1 with the old icon dimensions and the missing
scriptsfallback; nothing in this PR breaks Chrome, but pushing 1.0.2 to Chrome solo would trigger a needless re-review. Chrome stays on 1.0.1 until the next functional change, at which point both stores sync.Test plan
npx web-ext lint --source-dir=extension/ --ignore-files=icons/icon-source-400.png→ 0 errors, 3 informational warningsnpx web-ext buildproduces a valid 9.7 KB zip (tensorfeed_ai_status-1.0.2.zip)🤖 Generated with Claude Code