nix-shell no longer working

[wizzup]

$ nix-channel --list
nixos https://nixos.org/channels/nixos-unstable

$ git rev-parse HEAD
5452ee91d43f5f2d7dd539c16e82769c8c509787

$ nix-shell 
error:
       … while calling the 'derivationStrict' builtin
         at <nix/derivation-internal.nix>:37:12:
           36|
           37|   strict = derivationStrict drvAttrs;
             |            ^
           38|

       … while evaluating derivation 's25client'
         whose name attribute is located at /nix/store/v6c9aibkywz3szyxl0ybspa6lb9dw4bn-nixos/nixos/pkgs/stdenv/generic/make-derivation.nix:541:13

       … while evaluating attribute 'buildInputs' of derivation 's25client'
         at /nix/store/v6c9aibkywz3szyxl0ybspa6lb9dw4bn-nixos/nixos/pkgs/stdenv/generic/make-derivation.nix:593:13:
          592|             depsHostHost = elemAt (elemAt dependencies 1) 0;
          593|             buildInputs = elemAt (elemAt dependencies 1) 1;
             |             ^
          594|             depsTargetTarget = elemAt (elemAt dependencies 2) 0;

       (stack trace truncated; use '--show-trace' to show the full, detailed trace)

       error: function 'anonymous lambda' called with unexpected argument 'withStatic'
       at /nix/store/v6c9aibkywz3szyxl0ybspa6lb9dw4bn-nixos/nixos/pkgs/by-name/sd/sdl2-compat/package.nix:1:1:
            1| {
             | ^
            2|   cmake,

ping @BlueGone @Shawn8901

Also, it would be nice if the package is available on nixpkgs

[BlueGone]

I'm no longer an user of nix-shell, and a very occasional user of RTTR, I will not fix it myself.
To be future proof, I would recommend a gh action job that run on cmake or *nix changes, that check that it still compile on a nix env.
I still think nix environnement offer a nice and clean environnement for clean build and dev environnement, but if it is too costly to maintains, it may make sense to delete support for nix.

[Flamefire]

Unfortunately the core team lacks the resources to support the nix-shell. If anyone contributes a fix we will accept it, but can't actively maintain it. Especially when Nix makes breaking changes.

[Shawn8901]

I can check the error for the nix-shell for the repo later and check if it's fixable. There had been some topics that we need sdl.a files, that are not provided by nixpkgs builds. If I recall correctly there is also an issue in the repo about that.
Need to check what changed in nixpkgs here.

To have Rttr in nixpkgs a stable release is not build able by the nixpkgs default tooling when I last checked (don't remember what was the update breaking the build).
A new release would help here to get a stable rttr added to nixpkgs.
An git version I don't want to maintain.

Also the need of the s25 files at compile time is quite an issue for nixpkgs (need to be checked if my solving would be accepted)

That's why I abandoned upstreaming my package definition at some point.

[Flamefire]

Also the need of the s25 files at compile time is quite an issue for nixpkgs (need to be checked if my solving would be accepted)

Which files exactly?

A new release would help here to get a stable rttr added to nixpkgs.

@Flow86 We should indeed make a new release. It is long overdue. Maybe right after the PRs that are ready or fixing bugs are merged.

[Spikeone]

@Flamefire it'd be great but I think we should add at least some way to fix the 6th mission map - maybe we could even hardcode it as workaround. Only one of the original maps needs to be changed, and one should be changed. Maybe we could add some patch function on loading specific maps (e.g. also those we currently ship but which are made by bluebyte). Or we should ship the maps just as we do with the others.

Other than that specific issue, I'd agree that a release would be great!

[Flow86]

@Flow86 We should indeed make a new release. It is long overdue. Maybe right after the PRs that are ready or fixing bugs are merged.

I agree.

@Flamefire it'd be great but I think we should add at least some way to fix the 6th mission map - maybe we could even hardcode it as workaround. Only one of the original maps needs to be changed, and one should be changed. Maybe we could add some patch function on loading specific maps (e.g. also those we currently ship but which are made by bluebyte). Or we should ship the maps just as we do with the others.

Can we do that with Lua? what needs to be patched? Different issue, maybe @Spikeone can you open a new issue for that (if its not there already?)

[Flamefire]

Can we do that with Lua? what needs to be patched? Different issue, maybe @Spikeone can you open a new issue for that (if its not there already?)

There is an open PR which is almost finished. I can take it over the finish line when I got some time
#1683

[Shawn8901]

Also the need of the s25 files at compile time is quite an issue for nixpkgs (need to be checked if my solving would be accepted)

Which files exactly?

Offtopic to the issue, but as you asked:

I am talking about the path to the S25 game files her., but nixpkgs is very special in that matter.

Context: In nix everything might sit at a special place /nix/store/<some hash>..., that counts for applications, libraries, but could also be done for other static files (like our game files here).

If best case scenario for nixpkgs, i could pass the path to the game files as an argument on runtime.

That would allow the CI of nixpkgs to compile s25rttr, but not need any knowledge for the unfree files (the official ci will not touch any unfree software).
Then downstream (so nixpkgs) could first compile the game as unwrapped application, build a wrapper around that which requires the game files and builds on the endusers machine and that would then connect the dots between free and unfree software parts.

The other solution (which i thinking about) was to place the game files impurely on /var/lib, but that feels a bit alien in the nixpkgs ecosystem, but would be the way that i was heading to pack the days when i played around packaging s25rttr around 2024.

But the negative for me to add s25rttr to nixpkgs is really mostly that s25 stable versions are very rare (no criticism per se on that) thus its then quite some work to provide a working stable version in the context of nixpkgs for maintainers then.

[Shawn8901]

@wizzup in case you are interested and wanna try out, my current WIP for a package definition could be found Shawn8901/nixos-configuration@cf2fb4c

Any feedback is welcome if you like to leave some, you could create an issue in the repo for discussion or find me on matrix, discourse or unoffical discord (same user name as for github).

When there is a new release i'll take a look again to add s25 to nixpkgs.