Fix factory when validator has no constructor

This change introduces a less misleading exception when trying to
construct an instance and failing due to mismatched arguments
coming from ReflectionExceptions.

Author: alganet

library/NamespacedValidatorFactory.php

@@ -17,6 +17,7 @@
 use Respect\Validation\Transformers\ValidatorSpec;
 
 use function array_merge;
+use function Respect\Stringifier\stringify;
 use function sprintf;
 use function trim;
 use function ucfirst;
@@ -57,6 +58,8 @@ private function createValidatorSpec(ValidatorSpec $validatorSpec): Validator
     /** @param array<int, mixed> $arguments */
     private function createRule(string $ruleName, array $arguments = []): Validator
     {
+        $reflection = null;
+
         foreach ($this->rulesNamespaces as $namespace) {
             try {
                 /** @var class-string<Validator> $name */
@@ -72,12 +75,22 @@ private function createRule(string $ruleName, array $arguments = []): Validator
                     throw new InvalidClassException(sprintf('"%s" must be instantiable', $name));
                 }
 
-                return $reflection->newInstanceArgs($arguments);
+                break;
             } catch (ReflectionException) {
                 continue;
             }
         }
 
-        throw new ComponentException(sprintf('"%s" is not a valid rule name', $ruleName));
+        if (!$reflection) {
+            throw new ComponentException(sprintf('"%s" is not a valid rule name', $ruleName));
+        }
+
+        try {
+            return $reflection->newInstanceArgs($arguments);
+        } catch (ReflectionException) {
+            throw new InvalidClassException(
+                sprintf('"%s" could not be instantiated with arguments %s', $ruleName, stringify($arguments)),
+            );
+        }
     }
 }

tests/library/Validators/NoConstructor.php

@@ -0,0 +1,26 @@
+<?php
+
+/*
+ * Copyright (c) Alexandre Gomes Gaigalas <alganet@gmail.com>
+ * SPDX-License-Identifier: MIT
+ */
+
+declare(strict_types=1);
+
+namespace Respect\Validation\Test\Validators;
+
+use Respect\Validation\Message\Template;
+use Respect\Validation\Validators\Core\Simple;
+
+#[Template(
+    '{{subject}} must be a no-constructor validator',
+    '{{subject}} must not be a no-constructor validator',
+)]
+final class NoConstructor extends Simple
+{
+    public function isValid(mixed $input): bool
+    {
+        // Accept everything for test purposes
+        return true;
+    }
+}

tests/unit/NamespacedRuleFactoryTest.php

@@ -59,6 +59,19 @@ public function shouldDefineConstructorArgumentsWhenCreatingRule(): void
         self::assertSame($constructorArguments, $validator->validations);
     }
 
+    #[Test]
+    public function shouldThrowsAnExceptionOnConstructorReflectionFailure(): void
+    {
+        $constructorArguments = ['a', 'b'];
+
+        $factory = new NamespacedValidatorFactory(new StubTransformer(), [self::TEST_RULES_NAMESPACE]);
+
+        $this->expectException(InvalidClassException::class);
+        $this->expectExceptionMessage('"noConstructor" could not be instantiated with arguments `["a", "b"]`');
+
+        $factory->create('noConstructor', $constructorArguments);
+    }
+
     #[Test]
     public function shouldThrowsAnExceptionWhenRuleIsInvalid(): void
     {