Skip to content

Bug: Round numbers display incorrectly due to derived max_round calculation #202

@RemainingDelta

Description

@RemainingDelta

Overview

The bracket progress display sometimes shows incorrect round numbers because max_round is derived from the highest observed roundNum across current match data rather than using the totalRounds field already returned by the Matcherino API.

Steps to Reproduce Bug

  • Run a tournament where not all rounds have been generated yet in Matcherino
  • Check the bracket progress embed and observe the round count or rounds remaining being off

Impact

Staff see incorrect round numbers and rounds remaining in the bracket progress embed, making it harder to track tournament progress accurately.

Notes

Each match object already returns a totalRounds field from the Matcherino API which is never used. The fix should replace the derived max_round calculation at matcherino.py:587 with totalRounds taken directly from the match data. The current derivation (max(resolved_round) across all matches) is unreliable when rounds haven't been fully generated yet.

Acceptance Criteria

  • max_round is sourced from totalRounds on the match object instead of being derived
  • Bracket progress embed displays the correct round numbers and rounds remaining

Branch

202-Bug

Metadata

Metadata

Assignees

No one assigned

    Labels

    BugSomething isn't working

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions