Skip to content

Commit 09a64aa

Browse files
authored
Merge pull request #6 from ReforgeHQ/mfaga-readme
docs: add CONTRIBUTING.md
2 parents c8aa6c2 + 8baf613 commit 09a64aa

File tree

2 files changed

+93
-42
lines changed

2 files changed

+93
-42
lines changed

CONTRIBUTING.md

Lines changed: 87 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,87 @@
1+
# Table of Contents
2+
3+
- [How to Contribute](#how-to-contribute)
4+
- [Reporting Issues](#reporting-issues)
5+
- [Building Package](#building-package)
6+
- [Running Tests](#running-tests)
7+
- [Sending Pull Requests](#sending-pull-requests)
8+
- [Other Ways to Contribute](#other-ways-to-contribute)
9+
10+
# How to Contribute
11+
12+
Thanks for your interest in contributing to `@reforge-com/javascript`! Here are a few general
13+
guidelines on contributing and reporting bugs that we ask you to review. Following these guidelines
14+
helps to communicate that you respect the time of the contributors managing and developing this open
15+
source project. In return, they should reciprocate that respect in addressing your issue, assessing
16+
changes, and helping you finalize your pull requests. In that spirit of mutual respect, we endeavour
17+
to review incoming issues and pull requests within 10 days.
18+
19+
## Reporting Issues
20+
21+
Before reporting a new issue, please ensure that the issue was not already reported or fixed by
22+
searching through our [issues list](https://github.com/reforgehq/sdk-javascript/issues).
23+
24+
When creating a new issue, please be sure to include a **title and clear description**, as much
25+
relevant information as possible, and, if possible, a test case.
26+
27+
## Dependencies
28+
29+
- [NodeJS: v24.4.1](https://github.com/asdf-vm/asdf-nodejs)
30+
31+
```sh
32+
asdf plugin add nodejs https://github.com/asdf-vm/asdf-nodejs.git
33+
asdf install nodejs 24.4.1
34+
```
35+
36+
- [Yarn: v4.9.2](https://yarnpkg.com/getting-started/install)
37+
38+
```sh
39+
npm install -g corepack
40+
corepack enable
41+
corepack prepare yarn@4.9.2 --activate
42+
```
43+
44+
## Installing Package Dependencies
45+
46+
```sh
47+
yarn install
48+
```
49+
50+
## Building Package
51+
52+
```sh
53+
yarn build
54+
```
55+
56+
## Running Tests
57+
58+
```sh
59+
yarn test
60+
```
61+
62+
## Sending Pull Requests
63+
64+
Before sending a new pull request, take a look at existing pull requests and issues to see if the
65+
proposed change or fix has been discussed in the past, or if the change was already implemented but
66+
not yet released.
67+
68+
We expect new pull requests to include tests for any affected behavior, and, as we follow semantic
69+
versioning, we may reserve breaking changes until the next major version release.
70+
71+
## Other Ways to Contribute
72+
73+
We welcome anyone that wants to contribute to `@reforge-com/javascript` to triage and reply to open
74+
issues to help troubleshoot and fix existing bugs. Here is what you can do:
75+
76+
- Help ensure that existing issues follows the recommendations from the
77+
_[Reporting Issues](#reporting-issues)_ section, providing feedback to the issue's author on what
78+
might be missing.
79+
- Review and update the existing content of our [README](./README.md) with up-to-date instructions
80+
and code samples.
81+
- Review existing pull requests, and testing patches against real existing applications that use
82+
`@reforge-com/javascript`.
83+
- Write a test, or add a missing test case to an existing test.
84+
85+
Thanks again for your interest on contributing to `@reforge-com/javascript`!
86+
87+
:heart:

README.md

Lines changed: 6 additions & 42 deletions
Original file line numberDiff line numberDiff line change
@@ -150,47 +150,11 @@ it("shows the turbo button when the feature is enabled", () => {
150150
});
151151
```
152152
153-
[Reforge]: https://www.prefab.cloud/
154-
[jsDelivr]: https://www.jsdelivr.com/package/npm/@reforge-com/javascript
155-
156-
## Release Scripts
157-
158-
This package includes scripts to simplify the release process:
159-
160-
### Standard Release
161-
162-
To publish a new standard release (patch version):
163-
164-
```bash
165-
./publish-release.sh
166-
```
167-
168-
This script:
169-
170-
- Runs tests
171-
- Builds the package
172-
- Bumps the patch version
173-
- Publishes to npm with the `latest` tag
153+
## Contributing
174154
175-
### Pre-release
155+
Contributions are what make the open source community such an amazing place to learn, inspire, and
156+
create. Any contributions you make are **greatly appreciated**. For detailed contributing
157+
guidelines, please see [CONTRIBUTING.md](CONTRIBUTING.md)
176158
177-
To publish a pre-release version:
178-
179-
- Manually bump the version in package.json (e.g. bump the patch version and add -pre1)
180-
- `npm install` to update the lockfile
181-
182-
```bash
183-
./publish-prerelease.sh
184-
```
185-
186-
This script:
187-
188-
- Runs tests
189-
- Builds the package
190-
- Publishes to npm with the `pre` tag
191-
192-
To install the pre-release version:
193-
194-
```bash
195-
npm install @reforge-com/javascript
196-
```
159+
[Reforge]: https://www.prefab.cloud/
160+
[jsDelivr]: https://www.jsdelivr.com/package/npm/@reforge-com/javascript

0 commit comments

Comments
 (0)