Fix leaks in model_RDB_load, and in StatsRunInfo (key was not freed).

Author: alonre24

src/DAG/dag_parser.c

@@ -229,6 +229,7 @@ int DAG_CommandParser(RedisModuleCtx *ctx, RedisModuleString **argv, int argc, b
                     return REDISMODULE_ERR;
                 }
                 currentOp->devicestr = mto->devicestr;
+                RAI_HoldString(NULL, argv[arg_pos + 1]);
                 currentOp->runkey = argv[arg_pos + 1];
                 currentOp->mctx = RAI_ModelRunCtxCreate(mto);
             }
@@ -249,6 +250,7 @@ int DAG_CommandParser(RedisModuleCtx *ctx, RedisModuleString **argv, int argc, b
                 }
                 currentOp->devicestr = sto->devicestr;
                 const char *functionName = RedisModule_StringPtrLen(argv[arg_pos + 2], NULL);
+                RAI_HoldString(NULL, argv[arg_pos + 1]);
                 currentOp->runkey = argv[arg_pos + 1];
                 currentOp->sctx = RAI_ScriptRunCtxCreate(sto, functionName);
             }

src/backends/tensorflow.c

@@ -250,6 +250,7 @@ RAI_Model *RAI_ModelCreateTF(RAI_Backend backend, const char *devicestr, RAI_Mod
             char *msg = RedisModule_Calloc(60 + len, sizeof(*msg));
             sprintf(msg, "ERR Input node named \"%s\" not found in TF graph.", inputs[i]);
             RAI_SetError(error, RAI_EMODELIMPORT, msg);
+            RedisModule_Free(msg);
             return NULL;
         }
     }

src/model.c

@@ -107,19 +107,24 @@ static void *RAI_Model_RdbLoad(struct RedisModuleIO *io, int encver) {
         return NULL;
     }
 
+    for (size_t i = 0; i < ninputs; i++) {
+        RedisModule_Free(inputs[i]);
+    }
+    for (size_t i = 0; i < noutputs; i++) {
+        RedisModule_Free(outputs[i]);
+    }
     RedisModule_Free(inputs);
     RedisModule_Free(outputs);
     RedisModule_Free(buffer);
 
     RedisModuleCtx *stats_ctx = RedisModule_GetContextFromIO(io);
     RedisModuleString *stats_keystr =
         RedisModule_CreateStringFromString(stats_ctx, RedisModule_GetKeyNameFromIO(io));
-    const char *stats_devicestr = RedisModule_Strdup(devicestr);
-    RedisModuleString *stats_tag = RAI_HoldString(NULL, tag);
 
-    model->infokey =
-        RAI_AddStatsEntry(stats_ctx, stats_keystr, RAI_MODEL, backend, stats_devicestr, stats_tag);
+    model->infokey = RAI_AddStatsEntry(stats_ctx, stats_keystr, RAI_MODEL, backend, devicestr, tag);
 
+    RedisModule_FreeString(NULL, tag);
+    RedisModule_Free(devicestr);
     RedisModule_FreeString(NULL, stats_keystr);
 
     return model;
@@ -371,7 +376,6 @@ void RAI_ModelFree(RAI_Model *model, RAI_Error *err) {
     }
 
     RedisModule_FreeString(NULL, model->tag);
-
     RAI_RemoveStatsEntry(model->infokey);
 
     RedisModule_Free(model);

src/run_info.c

@@ -113,6 +113,8 @@ void RAI_FreeDagOp(RAI_DagOp *dagOp) {
             }
             array_free(dagOp->argv);
         }
+        if (dagOp->runkey)
+            RedisModule_FreeString(NULL, dagOp->runkey);
         // dagOp->inkeys is released on all argv release above
         // dagOp->outkeys is released on all argv release above
         // dagOp->outTensors is released on RunInfo after checking what tensors to

src/stats.c

@@ -109,6 +109,9 @@ void RAI_FreeRunStats(struct RedisAI_RunStats *rstats) {
         if (rstats->tag) {
             RedisModule_FreeString(NULL, rstats->tag);
         }
+        if (rstats->key) {
+            RedisModule_FreeString(NULL, rstats->key);
+        }
         RedisModule_Free(rstats);
     }
 }