Skip to content

Commit 6cd658a

Browse files
akri3ivsibirsk
andcommitted
Apply suggestions from code review
Co-authored-by: vsibirsk <57763370+vsibirsk@users.noreply.github.com>
1 parent 86fc1c8 commit 6cd658a

1 file changed

Lines changed: 32 additions & 32 deletions

File tree

stps/sig-virt/multiarch_support.md

Lines changed: 32 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -55,9 +55,9 @@ This STP serves as the **overall roadmap for testing**, detailing the scope, app
5555
This test plan checks if VMs schedules and live migrates correctly on a mixed architecture cluster
5656

5757
**In Scope:**
58-
- Create VMs for both AMD and ARM and confirm the cluster automatically places them on respective architecture node.
59-
- Test VM creation using both DataSources and Qcow2 images and ensure they always land on the right nodes.
60-
- Verify that VMs can Live Migrate between nodes of the same type (x86 to x86 and ARM to ARM) without stopping.
58+
- Create VMs for both AMD64 and ARM64 arch types and confirm the cluster automatically schedules them on respective architecture node.
59+
- Test VM creation using both golden image DataSources and custom Qcow2 images and ensure they always land on the right nodes.
60+
- Verify that VMs can Live Migrate between nodes of the same type (`amd64` to `amd64` and `arm64` to `arm64`) without issues.
6161

6262
**Out of Scope (Testing Scope Exclusions)**
6363
**Note:** Replace example rows with your actual out-of-scope items.
@@ -73,7 +73,7 @@ This test plan checks if VMs schedules and live migrates correctly on a mixed ar
7373

7474
- Verify Live Migration: Successfully migrate running VMs between same-arch nodes (x86 to x86, ARM to ARM).
7575

76-
- Verify Multi-Method Provisioning: Achieve 100% success rate for VM creation using both DataSources and Qcow2 images across both architectures.
76+
- Verify Multi-Method Provisioning: Achieve 100% success rate for VM creation using both golden image DataSources and custom Qcow2 images across both architectures.
7777

7878
#### **3. Test Strategy**
7979

@@ -82,19 +82,19 @@ The following test strategy considerations must be reviewed and addressed. Mark
8282

8383
| Item | Description | Applicable (Y/N or N/A) | Comments |
8484
| :----------------------------- | :----------------------------------------------------------------------------------------------------------------- | :---------------------- | :------- |
85-
| Functional Testing | Yes | | |
86-
| Automation Testing | Yes | | |
87-
| Performance Testing | N/A | | |
88-
| Security Testing | N/A | | |
89-
| Usability Testing | Yes | | |
90-
| Compatibility Testing | N/A | | |
91-
| Regression Testing | Yes | | |
92-
| Upgrade Testing | N/A | | |
93-
| Backward Compatibility Testing | N/A | | |
85+
| Functional Testing | | Yes | |
86+
| Automation Testing | | Yes | |
87+
| Performance Testing | | N/A | |
88+
| Security Testing | | N/A | |
89+
| Usability Testing | | Yes | |
90+
| Compatibility Testing | | N/A | |
91+
| Regression Testing | | Yes | |
92+
| Upgrade Testing | | N/A | |
93+
| Backward Compatibility Testing | | N/A | |
9494
| Dependencies | Dependent on deliverables from other components/products? Identify what is tested by which team. | | |
9595
| Cross Integrations | Does the feature affect other features/require testing by other components? Identify what is tested by which team. | | |
96-
| Monitoring | Yes | | |
97-
| Cloud Testing | N/A | | |
96+
| Monitoring | | Yes | |
97+
| Cloud Testing | | N/A | |
9898

9999
#### **4. Test Environment**
100100

@@ -106,11 +106,11 @@ The following test strategy considerations must be reviewed and addressed. Mark
106106
| **OCP & OpenShift Virtualization Version(s)** | OCP 4.21, CNV-4.21 | OCP 4.21 and OpenShift Virtualization 4.21 |
107107
| **CPU Virtualization** | Multi-arch cluster | 3 amd64 control-plane, 2 amd64 workers, and 2 arm64 workers |
108108
| **Compute Resources** | N/A | [e.g., Minimum per worker node: 8 vCPUs, 32GB RAM] |
109-
| **Special Hardware** | N/A | [e.g., Specific NICs for SR-IOV, GPU etc.] |
109+
| **Special Hardware** | N/A | [e.g., Specific NICs for SR-IOV, GPU etc.] |
110110
| **Storage** | io2-csi storage class | AWS EBS io2 CSI driver |
111111
| **Network** | N/A | [e.g., OVN-Kubernetes (default), Secondary Networks, Network Plugins, IPv4, IPv6, dual-stack] |
112112
| **Required Operators** | N/A | [e.g., NMState Operator] |
113-
| **Platform** | N/A | [e.g., Bare metal, AWS, Azure, GCP etc.] |
113+
| **Platform** | AWS | AWS for Arm nodes. |
114114
| **Special Configurations** | N/A | [e.g., Disconnected/air-gapped cluster, Proxy environment, FIPS mode enabled] |
115115

116116
#### **4.1. Testing Tools & Frameworks**
@@ -119,18 +119,18 @@ Document any **new or additional** testing tools, frameworks, or infrastructure
119119
for this feature. **Note:** Only list tools that are **new** or **different** from standard testing infrastructure.
120120
Leave empty if using standard tools.
121121

122-
| Category | Tools/Frameworks |
123-
| :----------------- | :--------------- |
124-
| **Test Framework** | |
125-
| **CI/CD** | |
126-
| **Other Tools** | |
122+
| Category | Tools/Frameworks |
123+
| :----------------- | :---------------- |
124+
| **Test Framework** | MultiArch cluster |
125+
| **CI/CD** | |
126+
| **Other Tools** | |
127127

128128
#### **5. Entry Criteria**
129129

130130
The following conditions must be met before testing can begin:
131131

132132
- [ ] Requirements and design documents are **approved and merged**
133-
- [V] Test environment can be **set up and configured** (see Section II.4 - Test Environment)
133+
- [ ] Test environment can be **set up and configured** (see Section II.4 - Test Environment)
134134
- [ ] Multi-CPU architecture support enabled in openshift-virtualization repo
135135

136136
#### **6. Risks**
@@ -141,15 +141,15 @@ justification in mitigation strategy.
141141
**Note:** Empty "Specific Risk" cells mean this must be filled. "N/A" means explicitly not applicable
142142
with justification.
143143

144-
| Risk Category | Specific Risk for This Feature | Mitigation Strategy | Status |
145-
| :------------------- | :--------------------------------------------------------------------------------- | :--------------------------------------------------------------------------------------------- | :----- |
146-
| Timeline/Schedule | Code Freeze on Jan 12th | [Your specific mitigation, e.g., "Prioritize P1 scenarios, automate in parallel"] | [ ] |
147-
| Test Coverage | enable multi-arch cluster support is under WIP | PR https://github.com/RedHatQE/openshift-virtualization-tests/pull/3147 | [ ] |
148-
| Test Environment | [Describe environment risks, e.g., "Requires GPU hardware, limited availability"] | [Your mitigation, e.g., "Reserve GPU nodes early, schedule tests in advance"] | [ ] |
149-
| Untestable Aspects | [List what cannot be tested, e.g., "Production scale with 10k VMs"] | [Your mitigation, e.g., "Test at smaller scale, extrapolate results, prod monitoring"] | [ ] |
150-
| Resource Constraints | [Describe resource issues, e.g., "Only 1 QE assigned, feature spans 3 components"] | [Your mitigation, e.g., "Focus automation on critical paths, coordinate with dev for testing"] | [ ] |
151-
| Dependencies | [Describe dependency risks, e.g., "Depends on Storage team delivering feature X"] | [Your mitigation, e.g., "Coordinate with Storage QE, have backup test plan"] | [ ] |
152-
| Other | [Any other specific risks] | [Mitigation strategy] | [ ] |
144+
| Risk Category | Specific Risk for This Feature | Mitigation Strategy | Status |
145+
| :------------------- | :------------------------------------------------------------------------------------------------------------------------------------------- | :--------------------------------------------------------------------------------------------- | :----- |
146+
| Timeline/Schedule | Code Freeze on Jan 12th | [Your specific mitigation, e.g., "Prioritize P1 scenarios, automate in parallel"] | [ ] |
147+
| Test Coverage | enable multi-arch cluster support is under WIP | PR https://github.com/RedHatQE/openshift-virtualization-tests/pull/3147 | [ ] |
148+
| Test Environment | For testing Live Migration we need 2 ARM64 nodes and two AMD64 nodes on a cluster current jenkins job deploys cluster with single ARM64 node | https://issues.redhat.com/browse/CNV-73894 | [ ] |
149+
| Untestable Aspects | [List what cannot be tested, e.g., "Production scale with 10k VMs"] | [Your mitigation, e.g., "Test at smaller scale, extrapolate results, prod monitoring"] | [ ] |
150+
| Resource Constraints | [Describe resource issues, e.g., "Only 1 QE assigned, feature spans 3 components"] | [Your mitigation, e.g., "Focus automation on critical paths, coordinate with dev for testing"] | [ ] |
151+
| Dependencies | [Describe dependency risks, e.g., "Depends on Storage team delivering feature X"] | [Your mitigation, e.g., "Coordinate with Storage QE, have backup test plan"] | [ ] |
152+
| Other | [Any other specific risks] | [Mitigation strategy] | [ ] |
153153

154154
#### **7. Known Limitations**
155155

0 commit comments

Comments
 (0)