Inconsistent save desynchronization

[waze3174]

title says save desynchronization, but it really should be a client desync

game version v1.2.2
rando version 0.9.5

OS: linux flatpak and windows

there is an issue i'm having where some checks, mainly progressive ones, seem to send themselves in double, at first, i received sword upgrade and wallet upgrades repeatedly when i was tabbed out and reading ressources for my run, then, it was bottles, and then magic. this happened while the game was running and connected to the archipelago server. though it did show that it got disconnected momentarily in the console.

i reloaded my game and the duplicates seemed to have dissapeared. leaving me with a game state that matched what the server had. but then things got weird.

whenever i closed the game and opened it the next day, certain checks would be reapplied to my save file, oddly enough, my hearts got set to 3, where i should have had 4-5 at that point. (my YAML had the 3 heart start setting.)

i did several tests, it seems the checks state is sent to the client upon connection, this SHOULD ensure matching data on both side, however, i'm getting inconsistencies that make seemingly no sense, notably, beans quantities go from 1 to 20, i'm getting double magic when the server only shows one progressive magic check, after drinking chateau romani, i had permanent infinite magic that not even editing the save could fix.

what my progression should be:
progressive sword: tier 2
progressive magic: tier 1 (half bar)
heart pieces: 2
heart containers: 3
bottle: 4 (2 regular, chateau romani and plain milk)

this is verified using the "/received" command using the text client.

the client state, after connecting though, is different. i should have 2 pieces of heart, yet i have 3, sometimes i have 3 hearts total health, sometimes 4, sometimes 5 or 6, sometimes i only got the starting sword, sometimes i have the tier 2 sword, other times it's tier 3, i should have 4 bottles. yet it only sometimes will set it to 6, sometimes the heart pieces show that i have none, too. and throughout all this, poptracker and the main archipelago tracker on the site show the correct information, it seems like the client itself is getting confused somewhere. I have verified this issue to be happening on windows and steam deck (same server, different OS) so i don't believe some cached save data is causing this issue as the linux install was brand new.

i tried adjusting the check state with a save editor to match the server, but these inconsistent checks keep pushing themselves back onto the modified save file, acting as a sort of cloud save from the server.

this whole thing seems to somewhat be related to quitting the game and resuming at a later time (aside from the initial time where it happened while connected), the edited, matching, save that i made seems to be fixed upon reconnection (minus an extra heart piece) as long as i keep playing, reconnect just once and all of these checks get mangled.

some sort of re synchronization command seems to be sorely missing from archipelago itself, I'm at a loss for solutions to this and i don't have access to the .apsave to make a more in depth assessment of this issue.

Is there a way to enable verbose logging in order to investigate further or if this is known, a workaround?

[waze3174]

i accidentally closed the issue while trying to upload this: message.txt

which is a log from archipelago around the time the game disconnected repeatedly, some time after i got my second progressive wallet

after discussing with G4M3R L1F3 on discord, this was his take.

G4M3R L1F3

"I will say that during dev testing, there has been a bug where the game would disconnect from the server and immediately reconnect. This would happen to some MM players at the same time and after reconnecting, these players were receiving all of their items again, causing duplicates. If the game saved after that, whether by interacting with an owl statue or from auto-saving, these duplicates would persist through sessions (in the same seed of course). Otherwise, the correct amount of items should be given.

This appears to be your case since you mentioned you got disconnected momentarily. Now, there's a pattern that Pixel has noticed that I want you to share: Just before the momentary disconnection, which item did you receive?"

i did save immediately after via SoT

[LittleCube-hax]

this commit of APCpp resolves the desync issue: RecompRando/APCpp@0201843

we'll release the fix soon™ and i'll close this once it's released

[waze3174]

I have tried building apcpp-glue.dll myself using your commit and it did not prevent my game from adding heart pieces to itself.

I might have done this wrong (first time doing a compilation) it took me all day and in the end. I couldnt build the dll and resorted to building on linux instead because of mbedtls errors

The resulting APCpp-glue.so did not fix the issue at least not as compiled from here

upon further testing in a new AP, seems like the issue is fixed or at least, it doesn't seem to be happening again so far.

[Ammako]

Can the current release be updated with a fixed dll for the time being? It's been three weeks since the fix was pushed, and nearly a month since the last release. People are using this in asyncs because it has had a proven track record of being stable for a long time now, and is marked as stable on the list of APWorlds.

Because of the way Majora's Mask/this randomizer works, you can just delete your save file and let the archipelago server populate a new one if you encounter problems (like OP here with the missing heart containers, or if you end up with more upgrades than you should have.) It probably doesn't really affect other players of the multiworld and won't result in softlocks either, so it's not absolutely urgent to get this fixed immediately, but if you have the environment set up to make new builds for this stuff already when you make new releases, might as well? Just as a quality of life thing.

Alternatively, I'm happy to write down build instructions for Windows (I don't know about Linux, sorry), and those who really want the fix early can build it for themselves, if you'd prefer that?

[Ammako]

Actually, I think there are issues still. I left my game running after I rebuilt the dll from the latest commits, to see if the problem would happen again. The problem I had noticed was that the game would seemingly hiccup randomly and re-receive every check from the server (and the screen would get spammed with item received notifications, like if someone had finished their game and sent out every remaining item.) This would happen every... 10-15 minutes or so?

That doesn't seem to happen anymore, or at least it hasn't happened again so far. but some checks do get consistently re-applied every time I save and reload. Consumables, specifically. Progressive upgrades are correct and don't get reapplied, but every time I save and reload the game, my Magic Beans count increases by however many I've received from other worlds, and the rupees that were sent by other players get added to my wallet every time. Infinite money hack! Just don't tell the banker...

I noticed that problem in older versions of the randomizer, which didn't have this disconnect/reconnect problem. So that might be a different bug entirely.

[LittleCube-hax]

yeah, the consumable thing is a quirk with MM that we've kept (to the player's advantage) until a better solution is found lol