[refactor] SONAR

1. clean up code smells and improve code structure

Author: ReallifeKip

src/Attributes/Defaults.php

@@ -24,7 +24,7 @@ final class Defaults
     /**
      * @param mixed $value Fallback value to apply when the property key is absent.
      */
-    public function __construct(
+    private function __construct(
         public mixed $value
     ) {}
 }

src/Attributes/KeepOnNull.php

@@ -19,5 +19,7 @@
 final class KeepOnNull
 {
     private function __construct()
-    {}
+    {
+        // Prevents manual instantiation of the attribute.
+    }
 }

src/Attributes/Lax.php

@@ -15,5 +15,7 @@
 final class Lax
 {
     private function __construct()
-    {}
+    {
+        // Prevents manual instantiation of the attribute.
+    }
 }

src/Attributes/SkipOnNull.php

@@ -15,5 +15,7 @@
 final class SkipOnNull
 {
     private function __construct()
-    {}
+    {
+        // Prevents manual instantiation of the attribute.
+    }
 }

src/Attributes/Spec.php

@@ -18,5 +18,7 @@
 final class Spec
 {
     private function __construct()
-    {}
+    {
+        // Prevents manual instantiation of the attribute.
+    }
 }

src/Attributes/Strict.php

@@ -16,5 +16,7 @@
 final class Strict
 {
     private function __construct()
-    {}
+    {
+        // Prevents manual instantiation of the attribute.
+    }
 }

src/Attributes/ValidateFromSelf.php

@@ -18,5 +18,7 @@
 final class ValidateFromSelf
 {
     private function __construct()
-    {}
+    {
+        // Prevents manual instantiation of the attribute.
+    }
 }

src/CLI/Cacher.php

@@ -119,7 +119,7 @@ private function indexDirectory(string $dir): void
                     $obj = $ref->newInstanceWithoutConstructor(); // NOSONAR
                     $method->invoke(null, $obj);
                     self::defaultValueValidate($class, $obj::defaultValues(), $ref->getProperties());
-                } catch (DefinitionException | Throwable $e) {
+                } catch (Throwable $e) {
                     match (true) {
                         !self::$silent && $e instanceof DefinitionException => fwrite(STDERR, "\033[33m[Skipped] $class: {$e->getMessage()}\033[0m\n"),
                         default => null

src/CLI/Writer.php

@@ -330,11 +330,11 @@ private static function tryInstantiateClass(string $class): void
             $ref = new ReflectionClass($class);
             ($method = $ref->getMethod('buildPropertyInheritanceChain'))->setAccessible(true); // NOSONAR
             $method->invoke(null, $ref->newInstanceWithoutConstructor()); // NOSONAR
-        } catch (DefinitionException | Throwable $e) {
-            if ($e instanceof DefinitionException && !self::$silent) {
-                fwrite(STDERR, "\033[33m[Skipped] $class: {$e->getMessage()}\033[0m\n");
-            }
-            // Silently skip classes that cannot be instantiated
+        } catch (Throwable $e) {
+            match (true) {
+                !self::$silent && $e instanceof DefinitionException => fwrite(STDERR, "\033[33m[Skipped] $class: {$e->getMessage()}\033[0m\n"),
+                default => null
+            };
         }
     }
 

src/CLI/writer/Markdown.php

@@ -82,7 +82,10 @@ public static function contentBlocksGenerate(array $classMap, array $entry): arr
             /** @var ReflectionProperty $propRef */
             $propRef  = $type['propertyRef'] ?? $ref->getProperty($type['propertyName']);
             $propDocs = self::docParser($propRef->getDocComment());
-            $required = $type['allowsNull'] ? '' : 'yes';
+            $required = match ($type['allowsNull']) {
+                true    => '',
+                default => 'yes'
+            };
             if ($type['isUnion']) {
                 /** @var UnionType $type */
                 $typeNames = array_map(self::unionTypeNamesParser(...), $type['types']);
@@ -99,7 +102,10 @@ public static function contentBlocksGenerate(array $classMap, array $entry): arr
                     self::$enums[$type['typename']['string']] = true;
                 }
             }
-            $desc    = $propDocs['desc'] ?: '-';
+            $desc = match (true) {
+                isset($propDocs['desc']) => $propDocs['desc'],
+                default                  => '-'
+            };
             $default = '-';
             if (isset($type['defaults'])) {
                 $default = $type['defaults'];