Route vision face detectors through self package context

The package-rename diagnostics showed that the Vision/MLKit face
detector creators were still using the canonical package context even
though the actual detector helper and model asset are owned by the
serving self APK.

In both the upstream/pre-fix and post-fix diagnostics runs, the
representative ThickFaceDetectorCreator probe still resolved
`createdContextPackage=com.google.android.gms` and then failed helper
initialization with `helperInit=RuntimeException: faceDetectorYN initialization failed`.
The same probe's forced self alternative resolved
`createdContextPackage=app.revanced.android.gms` and succeeded with
`helperInit=success`.

The supporting artifact probes explain why:
canonical had resources, but it did not expose `FaceDetectorHelper` or
the `face_detection_yunet_2023mar.onnx` asset, while self exposed both.
The diagnostics conclusion for these creators was:
`Evidence supports SELF ownership: FaceDetectorHelper depends on context.assets and only the self package exposes the face model asset in this run.`

Apply that ownership decision to all four remaining Vision/MLKit face
detector creators by replacing
`GooglePlayServicesUtil.getRemoteContext(...)` with an explicit self
package context. This keeps detector loading tied to the serving GmsCore
APK in side-by-side installs instead of the stock sidecar package.

Author: zappybiby

play-services-vision/core/src/main/kotlin/com/google/android/gms/vision/client/DynamiteNativeFaceDetectorCreator.kt

@@ -9,12 +9,12 @@ import android.content.Context
 import android.os.SystemClock
 import android.util.Log
 import androidx.annotation.Keep
-import com.google.android.gms.common.GooglePlayServicesUtil
 import com.google.android.gms.dynamic.IObjectWrapper
 import com.google.android.gms.dynamic.unwrap
 import com.google.android.gms.vision.face.internal.client.DetectionOptions
 import com.google.android.gms.vision.face.internal.client.INativeFaceDetector
 import com.google.android.gms.vision.face.internal.client.INativeFaceDetectorCreator
+import org.microg.gms.common.PackageUtils
 import org.microg.gms.vision.face.TAG
 import org.microg.gms.vision.face.FaceDetector
 import org.opencv.android.OpenCVLoader
@@ -27,16 +27,16 @@ class DynamiteNativeFaceDetectorCreator : INativeFaceDetectorCreator.Stub() {
         try {
             val elapsedRealtime = SystemClock.elapsedRealtime()
             val context = context.unwrap<Context>() ?: throw RuntimeException("Context is null")
-            val remoteContext = GooglePlayServicesUtil.getRemoteContext(context) ?: throw RuntimeException("remoteContext is null")
-            Log.d(TAG, "newFaceDetector: context: ${context.packageName} remoteContext: ${remoteContext.packageName}")
+            val detectorContext = context.createPackageContext(PackageUtils.getSelfPackageName(context), 0)
+            Log.d(TAG, "newFaceDetector: context: ${context.packageName} detectorContext: ${detectorContext.packageName}")
             if (!OpenCVLoader.initLocal()) {
                 throw RuntimeException("Unable to load OpenCV")
             }
             Log.d(TAG, "DynamiteNativeFaceDetectorCreator newFaceDetector: load <openCV> library in ${SystemClock.elapsedRealtime() - elapsedRealtime}ms")
-            return FaceDetector(remoteContext, faceDetectionOptions)
+            return FaceDetector(detectorContext, faceDetectionOptions)
         } catch (e: Throwable) {
             Log.w(TAG, "DynamiteNativeFaceDetectorCreator newFaceDetector load failed ", e)
             return null
         }
     }
-}
+}

play-services-vision/core/src/main/kotlin/com/google/android/gms/vision/face/ChimeraNativeFaceDetectorCreator.kt

@@ -9,12 +9,12 @@ import android.content.Context
 import android.os.SystemClock
 import android.util.Log
 import androidx.annotation.Keep
-import com.google.android.gms.common.GooglePlayServicesUtil
 import com.google.android.gms.dynamic.IObjectWrapper
 import com.google.android.gms.dynamic.unwrap
 import com.google.android.gms.vision.face.internal.client.DetectionOptions
 import com.google.android.gms.vision.face.internal.client.INativeFaceDetector
 import com.google.android.gms.vision.face.internal.client.INativeFaceDetectorCreator
+import org.microg.gms.common.PackageUtils
 import org.microg.gms.vision.face.FaceDetector
 import org.microg.gms.vision.face.TAG
 import org.opencv.android.OpenCVLoader
@@ -26,16 +26,16 @@ class ChimeraNativeFaceDetectorCreator : INativeFaceDetectorCreator.Stub() {
         try {
             val elapsedRealtime = SystemClock.elapsedRealtime()
             val context = context.unwrap<Context>() ?: throw RuntimeException("Context is null")
-            val remoteContext = GooglePlayServicesUtil.getRemoteContext(context) ?: throw RuntimeException("remoteContext is null")
-            Log.d(TAG, "newFaceDetector: context: ${context.packageName} remoteContext: ${remoteContext.packageName}")
+            val detectorContext = context.createPackageContext(PackageUtils.getSelfPackageName(context), 0)
+            Log.d(TAG, "newFaceDetector: context: ${context.packageName} detectorContext: ${detectorContext.packageName}")
             if (!OpenCVLoader.initLocal()) {
                 throw RuntimeException("Unable to load OpenCV")
             }
             Log.d(TAG, "ChimeraNativeFaceDetectorCreator newFaceDetector: load <openCV> library in ${SystemClock.elapsedRealtime() - elapsedRealtime}ms")
-            return FaceDetector(remoteContext, faceDetectionOptions)
+            return FaceDetector(detectorContext, faceDetectionOptions)
         } catch (e: Throwable) {
             Log.w(TAG, "ChimeraNativeFaceDetectorCreator newFaceDetector load failed ", e)
             return null
         }
     }
-}
+}

play-services-vision/core/src/main/kotlin/com/google/android/gms/vision/face/mlkit/FaceDetectorCreator.kt

@@ -9,12 +9,12 @@ import android.content.Context
 import android.os.SystemClock
 import android.util.Log
 import androidx.annotation.Keep
-import com.google.android.gms.common.GooglePlayServicesUtil
 import com.google.android.gms.dynamic.IObjectWrapper
 import com.google.android.gms.dynamic.unwrap
 import com.google.mlkit.vision.face.FaceDetectionOptions
 import com.google.mlkit.vision.face.aidls.IFaceDetector
 import com.google.mlkit.vision.face.aidls.IFaceDetectorCreator
+import org.microg.gms.common.PackageUtils
 import org.microg.gms.vision.face.TAG
 import org.microg.gms.vision.face.mlkit.FaceDetector
 import org.opencv.android.OpenCVLoader
@@ -27,16 +27,16 @@ class FaceDetectorCreator : IFaceDetectorCreator.Stub() {
         try {
             val elapsedRealtime = SystemClock.elapsedRealtime()
             val context = context.unwrap<Context>() ?: throw RuntimeException("Context is null")
-            val remoteContext = GooglePlayServicesUtil.getRemoteContext(context) ?: throw RuntimeException("remoteContext is null")
-            Log.d(TAG, "newFaceDetector: context: ${context.packageName} remoteContext: ${remoteContext.packageName}")
+            val detectorContext = context.createPackageContext(PackageUtils.getSelfPackageName(context), 0)
+            Log.d(TAG, "newFaceDetector: context: ${context.packageName} detectorContext: ${detectorContext.packageName}")
             if (!OpenCVLoader.initLocal()) {
                 throw RuntimeException("Unable to load OpenCV")
             }
             Log.d(TAG, "FaceDetectorCreator newFaceDetector: load <openCV> library in ${SystemClock.elapsedRealtime() - elapsedRealtime}ms")
-            return FaceDetector(remoteContext, faceDetectionOptions)
+            return FaceDetector(detectorContext, faceDetectionOptions)
         } catch (e: Throwable) {
             Log.w(TAG, "FaceDetectorCreator newFaceDetector load failed ", e)
             return null
         }
     }
-}
+}

play-services-vision/core/src/main/kotlin/com/google/mlkit/vision/face/bundled/internal/ThickFaceDetectorCreator.kt

@@ -9,12 +9,12 @@ import android.content.Context
 import android.os.SystemClock
 import android.util.Log
 import androidx.annotation.Keep
-import com.google.android.gms.common.GooglePlayServicesUtil
 import com.google.android.gms.dynamic.IObjectWrapper
 import com.google.android.gms.dynamic.unwrap
 import com.google.mlkit.vision.face.FaceDetectionOptions
 import com.google.mlkit.vision.face.aidls.IFaceDetector
 import com.google.mlkit.vision.face.aidls.IFaceDetectorCreator
+import org.microg.gms.common.PackageUtils
 import org.microg.gms.vision.face.TAG
 import org.microg.gms.vision.face.mlkit.FaceDetector
 import org.opencv.android.OpenCVLoader
@@ -27,16 +27,16 @@ class ThickFaceDetectorCreator : IFaceDetectorCreator.Stub() {
         try {
             val elapsedRealtime = SystemClock.elapsedRealtime()
             val context = context.unwrap<Context>() ?: throw RuntimeException("Context is null")
-            val remoteContext = GooglePlayServicesUtil.getRemoteContext(context) ?: throw RuntimeException("remoteContext is null")
-            Log.d(TAG, "ThickFaceDetectorCreator newFaceDetector: context: ${context.packageName} remoteContext: ${remoteContext.packageName}")
+            val detectorContext = context.createPackageContext(PackageUtils.getSelfPackageName(context), 0)
+            Log.d(TAG, "ThickFaceDetectorCreator newFaceDetector: context: ${context.packageName} detectorContext: ${detectorContext.packageName}")
             if (!OpenCVLoader.initLocal()) {
                 throw RuntimeException("Unable to load OpenCV")
             }
             Log.d(TAG, "ThickFaceDetectorCreator newFaceDetector: load <openCV> library in ${SystemClock.elapsedRealtime() - elapsedRealtime}ms")
-            return FaceDetector(remoteContext, faceDetectionOptions)
+            return FaceDetector(detectorContext, faceDetectionOptions)
         } catch (e: Throwable) {
             Log.w(TAG, "ThickFaceDetectorCreator newFaceDetector load failed ", e)
             return null
         }
     }
-}
+}