Skip to content

Commit d02392a

Browse files
committed
changed some presenter descriptions to combat regex catastrophic backtracking
1 parent b931803 commit d02392a

3 files changed

Lines changed: 6 additions & 11 deletions

File tree

app/V1Module/presenters/SubmitPresenter.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -342,7 +342,7 @@ public function checkResubmit(string $id)
342342
* @POST
343343
* @param string $id Identifier of the solution
344344
* @Param(type="post", name="debug", validation="bool", required=false,
345-
* "Debugging resubmit with all logs and outputs")
345+
* description="Debugging resubmit with all logs and outputs")
346346
* @throws ForbiddenRequestException
347347
* @throws InvalidArgumentException
348348
* @throws NotFoundException

app/V1Module/presenters/UploadedFilesPresenter.php

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -168,8 +168,7 @@ public function checkDownload(string $id, ?string $entry = null, ?string $simila
168168
* @Param(type="query", name="entry", required=false, validation="string:1..",
169169
* description="Name of the entry in the ZIP archive (if the target file is ZIP)")
170170
* @Param(type="query", name="similarSolutionId", required=false, validation="string:36",
171-
* description="Id of an assignment solution which has detected possible plagiarism in this file.
172-
* This is basically a shortcut (hint) for ACLs.")
171+
* description="Id of an assignment solution which has detected possible plagiarism in this file. This is basically a shortcut (hint) for ACLs.")
173172
* @throws \Nette\Application\AbortException
174173
* @throws \Nette\Application\BadRequestException
175174
*/
@@ -210,8 +209,7 @@ public function checkContent(string $id, ?string $entry = null, ?string $similar
210209
* @Param(type="query", name="entry", required=false, validation="string:1..",
211210
* description="Name of the entry in the ZIP archive (if the target file is ZIP)")
212211
* @Param(type="query", name="similarSolutionId", required=false, validation="string:36",
213-
* description="Id of an assignment solution which has detected possible plagiarism in this file.
214-
* This is basically a shortcut (hint) for ACLs.")
212+
* description="Id of an assignment solution which has detected possible plagiarism in this file. This is basically a shortcut (hint) for ACLs.")
215213
*/
216214
public function actionContent(string $id, ?string $entry = null)
217215
{

app/V1Module/presenters/UsersPresenter.php

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -434,18 +434,15 @@ public function checkUpdateSettings(string $id)
434434
* @Param(type="post", name="pointsChangedEmails", validation="bool", required=false,
435435
* description="Flag if email should be sent to user when the points were awarded for assignment")
436436
* @Param(type="post", name="assignmentSubmitAfterAcceptedEmails", validation="bool", required=false,
437-
* description="Flag if email should be sent to group supervisor if a student submits new solution
438-
* for already accepted assignment")
437+
* description="Flag if email should be sent to group supervisor if a student submits new solution for already accepted assignment")
439438
* @Param(type="post", name="assignmentSubmitAfterReviewedEmails", validation="bool", required=false,
440-
* description="Flag if email should be sent to group supervisor if a student submits new solution
441-
* for already reviewed and not accepted assignment")
439+
* description="Flag if email should be sent to group supervisor if a student submits new solution for already reviewed and not accepted assignment")
442440
* @Param(type="post", name="exerciseNotificationEmails", validation="bool", required=false,
443441
* description="Flag if notifications sent by authors of exercises should be sent via email.")
444442
* @Param(type="post", name="solutionAcceptedEmails", validation="bool", required=false,
445443
* description="Flag if notification should be sent to a student when solution accepted flag is changed.")
446444
* @Param(type="post", name="solutionReviewRequestedEmails", validation="bool", required=false,
447-
* description="Flag if notification should be send to a teacher when a solution reviewRequested flag
448-
* is chagned in a supervised/admined group.")
445+
* description="Flag if notification should be send to a teacher when a solution reviewRequested flag is chagned in a supervised/admined group.")
449446
* @throws NotFoundException
450447
*/
451448
public function actionUpdateSettings(string $id)

0 commit comments

Comments
 (0)