improved requirement string generation algorithm

Author: eceltov

app/helpers/Swagger/AnnotationData.php

@@ -83,19 +83,15 @@ private function getBodyAnnotation(): string | null
         foreach ($this->bodyParams as $bodyParam) {
             $body->addValue($bodyParam->toPropertyAnnotation());
             if ($bodyParam->required) {
-                $required[] = $bodyParam->name;
+                // add quotes around the names (required by the swagger generator)
+                $required[] = '"' . $bodyParam->name . '"';
             }
         }
 
         // add a list of required properties
         if (count($required) > 0) {
             // stringify the list (it has to be in '{"name1","name1",...}' format)
-            $requiredString = "{";
-            foreach ($required as $name) {
-                $requiredString .= "\"$name\",";
-            }
-            $requiredString .= "}";
-
+            $requiredString = "{" . implode(",", $required) . "}";
             $body->addValue("required=" . $requiredString);
         }
 

app/helpers/Swagger/ParameterConstraints.php

@@ -16,7 +16,7 @@ class ParameterConstraints
      */
     public function __construct(?string $pattern = null, ?int $minLength = null, ?int $maxLength = null)
     {
-        # swagger patterns must not contain the bounding '/.../' slashes
+        // swagger patterns must not contain the bounding '/.../' slashes
         if ($pattern != null && strlen($pattern) >= 2) {
             $pattern = substr($pattern, 1, -1);
         }