added Format attribute caching

Author: eceltov

app/V1Module/presenters/base/BasePresenter.php

@@ -207,16 +207,22 @@ public function getFormatInstance(): MetaFormat
 
     private function processParams(ReflectionMethod $reflection)
     {
+        $actionPath = get_class($this) . $reflection->name;
+
+        // cache whether the action has a Format attribute
+        if (!FormatCache::formatAttributeStringCached($actionPath)) {
+            $extractedFormat = MetaFormatHelper::extractFormatFromAttribute($reflection);
+            FormatCache::cacheFormatAttributeString($actionPath, $extractedFormat);
+        }
         // use a method specialized for formats if there is a format available
-        $format = MetaFormatHelper::extractFormatFromAttribute($reflection);
+        $format = FormatCache::getFormatAttributeString($actionPath);
         if ($format !== null) {
             $this->requestFormatInstance = $this->processParamsFormat($format, null);
         }
 
         // handle loose parameters
 
         // cache the data from the loose attributes to improve performance
-        $actionPath = get_class($this) . $reflection->name;
         if (!FormatCache::looseParametersCached($actionPath)) {
             $newParamData = MetaFormatHelper::extractRequestParamData($reflection);
             FormatCache::cacheLooseParameters($actionPath, $newParamData);

app/helpers/MetaFormats/FormatCache.php

@@ -19,6 +19,9 @@ class FormatCache
     // this array caches loose attribute data which are added over time by the presenters
     private static array $actionToRequestParamDataMap = [];
 
+    // array that caches Format attribute format strings for actions
+    private static array $actionToFormatMap = [];
+
     /**
      * @param string $actionPath The presenter class name joined with the name of the action method.
      * @return bool Returns whether the loose parameters of the action are cached.
@@ -28,6 +31,33 @@ public static function looseParametersCached(string $actionPath): bool
         return array_key_exists($actionPath, self::$actionToRequestParamDataMap);
     }
 
+    /**
+     * @param string $actionPath The presenter class name joined with the name of the action method.
+     * @return bool Returns whether the action Format attribute string was cached.
+     */
+    public static function formatAttributeStringCached(string $actionPath): bool
+    {
+        return array_key_exists($actionPath, self::$actionToFormatMap);
+    }
+
+    /**
+     * @param string $actionPath The presenter class name joined with the name of the action method.
+     * @param string $format The attribute format string.
+     */
+    public static function cacheFormatAttributeString(string $actionPath, string $format)
+    {
+        self::$actionToFormatMap[$actionPath] = $format;
+    }
+
+    /**
+     * @param string $actionPath The presenter class name joined with the name of the action method.
+     * @return bool Returns action Format attribute string.
+     */
+    public static function getFormatAttributeString(string $actionPath): string
+    {
+        return self::$actionToFormatMap[$actionPath];
+    }
+
     /**
      * @param string $actionPath The presenter class name joined with the name of the action method.
      * @return array Returns the cached RequestParamData array of the loose attributes.