fix(numpy) - Pass correct contiguous array to C level

Author: protocolstardust

rayforce/types/containers/vector.py

@@ -45,6 +45,14 @@
     "int64": r.TYPE_I64,
     "float64": r.TYPE_F64,
 }
+_RAY_TO_NUMPY: dict[int, str] = {
+    r.TYPE_U8: "uint8",
+    r.TYPE_B8: "bool",
+    r.TYPE_I16: "int16",
+    r.TYPE_I32: "int32",
+    r.TYPE_I64: "int64",
+    r.TYPE_F64: "float64",
+}
 # Auto-widen numpy dtypes that have no direct rayforce equivalent
 _NUMPY_WIDEN: dict[str, str] = {
     "float16": "float64",
@@ -222,6 +230,9 @@ def from_numpy(cls, arr: t.Any, *, ray_type: type[RayObject] | int | None = None
 
         if ray_type is not None and arr.dtype.kind not in ("M", "m"):
             type_code = abs(ray_type if isinstance(ray_type, int) else ray_type.type_code)
+            target_dtype = _RAY_TO_NUMPY.get(type_code)
+            if target_dtype is not None and arr.dtype.name != target_dtype:
+                arr = np.ascontiguousarray(arr.astype(target_dtype))
             return cls(ptr=FFI.init_vector_from_raw_buffer(type_code, len(arr), arr.data))
 
         if (maybe_code := _NUMPY_TO_RAY.get(arr.dtype.name)) is not None:

tests/test_numpy_compatibility.py

@@ -1867,17 +1867,29 @@ def test_1d_still_works(self):
 # ============================================================================
 
 
-class TestFromNumpyExplicitRayTypeMismatch:
-    """Explicit ray_type with buffer element size mismatch."""
+class TestFromNumpyExplicitRayTypeCast:
+    """Explicit ray_type with different numpy dtype casts values correctly."""
 
-    def test_float32_as_f64_raises(self):
-        """float32 (4 bytes) → F64 (8 bytes): buffer too small."""
+    def test_float32_as_f64(self):
+        """float32 → F64: values are cast, not reinterpreted."""
         arr = np.array([1.0, 2.0], dtype=np.float32)
-        with pytest.raises(ValueError, match="Buffer too small"):
-            t.Vector.from_numpy(arr, ray_type=t.F64)
+        vec = t.Vector.from_numpy(arr, ray_type=t.F64)
+        assert vec.to_list() == [1.0, 2.0]
 
-    def test_int16_as_i64_raises(self):
-        """int16 (2 bytes) → I64 (8 bytes): buffer too small."""
+    def test_int16_as_i64(self):
+        """int16 → I64: values are cast, not reinterpreted."""
         arr = np.array([1, 2], dtype=np.int16)
-        with pytest.raises(ValueError, match="Buffer too small"):
-            t.Vector.from_numpy(arr, ray_type=t.I64)
+        vec = t.Vector.from_numpy(arr, ray_type=t.I64)
+        assert vec.to_list() == [1, 2]
+
+    def test_int64_as_i16(self):
+        """int64 → I16: values are cast, not reinterpreted."""
+        arr = np.array([1, 2, 3, 4], dtype=np.int64)
+        vec = t.Vector.from_numpy(arr, ray_type=t.I16)
+        assert vec.to_list() == [1, 2, 3, 4]
+
+    def test_int64_as_i32(self):
+        """int64 → I32: values are cast, not reinterpreted."""
+        arr = np.array([1, 2, 3, 4], dtype=np.int64)
+        vec = t.Vector.from_numpy(arr, ray_type=t.I32)
+        assert vec.to_list() == [1, 2, 3, 4]