Skip to content

Commit f182293

Browse files
committed
Consolidate school import abilities into one method
1 parent dbcaa1f commit f182293

File tree

1 file changed

+9
-4
lines changed

1 file changed

+9
-4
lines changed

app/models/ability.rb

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -121,19 +121,24 @@ def define_school_student_abilities(user:, school:)
121121
can(%i[show_finished set_finished show_status unsubmit submit], SchoolProject, project: { user_id: user.id, lesson_id: nil }, school_id: school.id)
122122
end
123123

124-
def define_editor_admin_abilities(user)
125-
return unless user&.admin?
124+
def define_school_import_abilities(user)
125+
return unless user&.admin? || user&.experience_cs_admin?
126126

127127
can :import, School
128128
can :read, :school_import_job
129129
end
130130

131+
def define_editor_admin_abilities(user)
132+
return unless user&.admin?
133+
134+
define_school_import_abilities(user)
135+
end
136+
131137
def define_experience_cs_admin_abilities(user)
132138
return unless user&.experience_cs_admin?
133139

134140
can %i[read create update destroy], Project, user_id: nil
135-
can :import, School
136-
can :read, :school_import_job
141+
define_school_import_abilities(user)
137142
end
138143

139144
def school_teacher_can_manage_lesson?(user:, school:, lesson:)

0 commit comments

Comments
 (0)