update Project.with_user to not call profile api when user is a student (#627)

## Status

- Closes #596 

## What's changed?

Update `Project.with_user` to not call profile api when user is a
student as this call will always fail. Students cannot use that API at
the moment so this calls gets 500.

No outwards change should happen, but hopefully this will stop both
Profile and Editor API sentry being full of this error.

As far as I can tell, this call happens when a student first opens a
project (lesson). As they do not have their own remix yet, the fallback
gets the project, and that calls the `.with_user` that is causing this
problem.

Author: peconia

app/models/project.rb

@@ -53,6 +53,9 @@ def self.with_users(current_user)
   end
 
   def with_user(current_user)
+    # students cannot call the Profile API so do not even try
+    return [self, nil] if current_user&.student?
+
     school = School.find_by(id: school_id)
     students = SchoolStudent::List.call(school:, token: current_user.token,
                                         student_ids: [user_id])[:school_students] || []

spec/models/project_spec.rb

@@ -274,13 +274,40 @@
       expect(pair).to eq([project, user])
     end
 
+    it 'calls the Profile API to fetch the user' do
+      project = create(:project, user_id: student.id, school_id: school.id)
+
+      allow(SchoolStudent::List).to receive(:call).and_call_original
+
+      project.with_user(teacher)
+
+      expect(SchoolStudent::List).to have_received(:call).with(
+        school:,
+        token: teacher.token,
+        student_ids: [student.id]
+      )
+    end
+
     it 'returns a nil value if the member has no profile account' do
       user_id = SecureRandom.uuid
       project = create(:project, user_id:)
 
       pair = project.with_user(teacher)
       expect(pair).to eq([project, nil])
     end
+
+    context 'when current_user is a student' do
+      it 'returns the project with nil user without calling Profile API' do
+        project = create(:project, user_id: student.id, school_id: school.id)
+
+        allow(SchoolStudent::List).to receive(:call)
+
+        pair = project.with_user(student)
+
+        expect(pair).to eq([project, nil])
+        expect(SchoolStudent::List).not_to have_received(:call)
+      end
+    end
   end
 
   describe '#last_edited_at' do