Addresses review comments

Author: StephenNneji

.github/workflows/run_ruff.yml

@@ -8,7 +8,5 @@ jobs:
     steps:
       - uses: actions/checkout@v4
       - uses: astral-sh/ruff-action@v3
-        with:
-          version: "0.12.x"
       - run: ruff format --check
 

pyproject.toml

@@ -38,4 +38,5 @@ mark-parentheses = false
 [tool.ruff.lint.pydocstyle]
 convention = "numpy"
 
-
+[tool.ruff.lint.isort]
+known-first-party = ["ratapi.rat_core"]

ratapi/examples/normal_reflectivity/custom_XY_DSPC.py

@@ -1,5 +1,7 @@
 """A custom XY model for a supported DSPC bilayer."""
 
+from math import sqrt
+
 import numpy as np
 from scipy.special import erf
 
@@ -128,12 +130,9 @@ def layer(z, prevLaySurf, thickness, height, Sigma_L, Sigma_R):
     right = prevLaySurf + thickness
 
     # Make our heaviside
-    a = (z - left) / ((2**0.5) * Sigma_L)
-    b = (z - right) / ((2**0.5) * Sigma_R)
-
-    erf_a = erf(a)
-    erf_b = erf(b)
+    erf_left = erf((z - left) / (sqrt(2) * Sigma_L))
+    erf_right = erf((z - right) / (sqrt(2) * Sigma_R))
 
-    VF = np.array((height / 2) * (erf_a - erf_b))
+    VF = np.array((0.5 * height) * (erf_left - erf_right))
 
     return VF, right

ratapi/utils/plotting.py

@@ -677,6 +677,9 @@ def plot_corner(
     hist2d_kwargs : dict
         Extra keyword arguments to pass to the 2d histograms.
         Default is {'density': True, 'bins': 25}
+    progress_callback: Union[Callable[[int, int], None], None]
+        Callback function for providing progress during plot creation
+        First argument is current completed sub plot and second is total number of sub plots
 
     Returns
     -------

setup.py

@@ -61,7 +61,7 @@ class BuildExt(build_ext):
     """A custom build extension for adding compiler-specific options."""
 
     c_opts = {
-        "msvc": ["/O3", "/EHsc", "/openmp"],
+        "msvc": ["/O2", "/EHsc", "/openmp"],
         "unix": ["-O2", "-fopenmp", "-std=c++11"],
     }
     l_opts = {