removed walkup as it is unstable

Author: alexhroom

RATapi/project.py

@@ -7,7 +7,6 @@
 import warnings
 from enum import Enum
 from pathlib import Path
-from sys import version_info
 from textwrap import indent
 from typing import Annotated, Any, Callable, Union
 
@@ -972,28 +971,15 @@ def try_relative_to(path: Path, relative_to: Path) -> Path:
     abs_path = Path(path).resolve()
     abs_base = Path(relative_to).resolve()
 
-    # 'walking up' paths is only added in Python 3.12
-    if version_info.minor < 12:
-        try:
-            relative_path = abs_path.relative_to(abs_base)
-        except ValueError as err:
-            warnings.warn(
-                "Could not save a custom file path as relative to the project directory. "
-                "This may mean the project may not open on other devices. "
-                f"Error message: {err}",
-                stacklevel=2,
-            )
-            return abs_path
-    else:
-        try:
-            relative_path = abs_path.relative_to(abs_base, walk_up=True)
-        except ValueError as err:
-            warnings.warn(
-                "Could not save a custom file path as relative to the project directory. "
-                "This may mean the project may not open on other devices. "
-                f"Error message: {err}",
-                stacklevel=2,
-            )
-            return abs_path
+    try:
+        relative_path = abs_path.relative_to(abs_base)
+    except ValueError:
+        warnings.warn(
+            "Could not save custom file path as relative to the project directory. "
+            "To ensure that your project works on other devices, make sure your custom files "
+            "are in a subfolder of the project save location.",
+            stacklevel=2,
+        )
+        return abs_path
 
     return relative_path

tests/test_project.py

@@ -4,7 +4,6 @@
 import tempfile
 import warnings
 from pathlib import Path
-from sys import version_info
 from typing import Callable
 
 import numpy as np
@@ -1574,7 +1573,7 @@ def test_save_load(project, request):
 
 
 def test_relative_paths():
-    """Test that ``try_relative_to`` correctly creates relative paths."""
+    """Test that ``try_relative_to`` correctly creates relative paths to subfolders."""
 
     with tempfile.TemporaryDirectory() as tmp:
         data_path = Path(tmp, "data/myfile.dat")
@@ -1583,19 +1582,16 @@ def test_relative_paths():
 
 
 def test_relative_paths_version():
-    """Test that we only walk up paths on Python 3.12 or greater."""
+    """Test that we get a warning for trying to walk up paths."""
 
     data_path = "/tmp/project/data/mydata.dat"
     relative_path = "/tmp/project/project_path/myproj.dat"
 
-    if version_info.minor >= 12:
-        with warnings.catch_warnings():
-            warnings.simplefilter("error")
-            assert RATapi.project.try_relative_to(data_path, relative_path) == Path("../../data/mydata.dat")
-    else:
-        with pytest.warns(
-            match="Could not save a custom file path as relative to the project directory. "
-            "This may mean the project may not open on other devices. "
-            "Error message:"
-        ):
-            assert RATapi.project.try_relative_to(data_path, relative_path) == Path("/tmp/project/data/mydata.dat")
+    with pytest.warns(
+        match="Could not save custom file path as relative to the project directory. "
+        "To ensure that your project works on other devices, make sure your custom files "
+        "are in a subfolder of the project save location."
+    ):
+        assert (
+            RATapi.project.try_relative_to(data_path, relative_path) == Path("/tmp/project/data/mydata.dat").resolve()
+        )