added warning for fields clearing

Author: alexhroom

RATapi/models.py

@@ -59,6 +59,7 @@ class Signal(RATModel):
 
     def __setattr__(self, name, value):
         if name == "type":
+            warnings.warn(f"Changing the type of {self.name} clears its source and value fields.", stacklevel=2)
             for attr in ["source", "value_1", "value_2", "value_3", "value_4", "value_5"]:
                 with warnings.catch_warnings():
                     warnings.simplefilter("ignore")

tests/test_models.py

@@ -336,7 +336,7 @@ def test_contrast_bad_ratio():
 
 @pytest.mark.parametrize("model", [RATapi.models.Background, RATapi.models.Resolution])
 def test_type_change_clear(model):
-    """If the type of a background or resolution is changed, it should wipe the other fields."""
+    """If the type of a background or resolution is changed, it should wipe the other fields and warn the user."""
 
     model_instance = model(
         name="Test",
@@ -349,6 +349,7 @@ def test_type_change_clear(model):
         value_5="val5",
     )
 
-    model_instance.type = "data"
+    with pytest.warns(UserWarning, match="Changing the type of Test clears its source and value fields."):
+        model_instance.type = "data"
     for attr in ["source", "value_1", "value_2", "value_3", "value_4", "value_5"]:
         assert getattr(model_instance, attr) == ""