Skip to content

Commit 6e15fec

Browse files
authored
Remove finalizers as ArrayPool is a managed resource (#15)
1 parent 895e443 commit 6e15fec

3 files changed

Lines changed: 8 additions & 28 deletions

File tree

FuzzySharp/FuzzySharp.csproj

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
<Project Sdk="Microsoft.NET.Sdk">
22

33
<PropertyGroup>
4-
<AssemblyVersion>3.0.7.0</AssemblyVersion>
5-
<FileVersion>3.0.7.0</FileVersion>
6-
<Version>3.0.7</Version>
7-
<PackageVersion>3.0.7</PackageVersion>
4+
<AssemblyVersion>3.0.8.0</AssemblyVersion>
5+
<FileVersion>3.0.8.0</FileVersion>
6+
<Version>3.0.8</Version>
7+
<PackageVersion>3.0.8</PackageVersion>
88
<Authors>Jacob Bayer;Yevhen Cherkes</Authors>
99
<Company />
1010
<Description>

FuzzySharp/Utils/CharMaskBuffer.cs

Lines changed: 4 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -97,27 +97,13 @@ public ReadOnlySpan<ulong> GetOrDefault(T key, ReadOnlySpan<ulong> fallback)
9797
return TryGetMask(key, out var mask) ? mask : fallback;
9898
}
9999

100-
~CharMaskBuffer()
101-
{
102-
Dispose(false);
103-
}
104-
105100
public void Dispose()
106-
{
107-
Dispose(true);
108-
GC.SuppressFinalize(this);
109-
}
110-
111-
private void Dispose(bool disposing)
112101
{
113102
if (_disposed) return;
114-
115-
if (disposing)
116-
{
117-
_indexMap.Dispose();
118-
_pool.Return(_buffer);
119-
_pool.Return(_zeroMask);
120-
}
103+
104+
_indexMap.Dispose();
105+
_pool.Return(_buffer);
106+
_pool.Return(_zeroMask);
121107

122108
_disposed = true;
123109
}

FuzzySharp/Utils/DictionarySlimPooled.cs

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -398,12 +398,6 @@ public void Dispose() { }
398398
}
399399

400400
public void Dispose()
401-
{
402-
Clear();
403-
GC.SuppressFinalize(this);
404-
}
405-
406-
~DictionarySlimPooled()
407401
{
408402
Clear();
409403
}

0 commit comments

Comments
 (0)