Role of languageserver going ahead

[lokesh-krishna]

Been a longtime user of R.Nvim and have been trying out the new inbuilt language server for completions. Works great!

Would I be losing anything if I were to drop r-languageserver altogether?

[PMassicotte]

You will miss things like rename, go to definition, etc. But this is something I would like to tackle in a near future.

[mohelm]

are there any downsides to using them in parallel?
also: many thanks for the plugin. it is awesome.

[PMassicotte]

are there any downsides to using them in parallel? also: many thanks for the plugin. it is awesome.

You can use both and disable what you do not need from languageserver

options(
  languageserver.server_capabilities = list(
    hoverProvider = FALSE,
    signatureHelpProvider = FALSE,
    completionProvider = FALSE,
    completionItemResolve = FALSE
  )
)

R.nvim/doc/R.nvim.txt

Line 1447 in d8eeaab

6.10. Language server *R-language-server*

[PMassicotte]

Just a quick preview:

[jalvesaq]

Very nice!

One possible issue: nvimcom runs in our real R session, which means that if R is busy with a length operation nvimcom will be unresponsive. However, for any static analysis of code, not depending on knowledge of what objects are in R's memory, you could run another R instance as a job in the background. This is what rlanguageserver does, although it doesn't seem to be very efficient in computer resources usage.

[PMassicotte]

Very nice!

One possible issue: nvimcom runs in our real R session, which means that if R is busy with a length operation nvimcom will be unresponsive. However, for any static analysis of code, not depending on knowledge of what objects are in R's memory, you could run another R instance as a job in the background. This is what rlanguageserver does, although it doesn't seem to be very efficient in computer resources usage.

Good call. I will do some tests during holidays and see how it goes!

[jalvesaq]

@PMassicotte implemented many features in our language server, and my .~/Rprofile now has this:

# Disable languageserver features
options(
    languageserver.server_capabilities = list(
        # Use R.nvim's built-in language server
        hoverProvider = FALSE,
        signatureHelpProvider = FALSE,
        completionProvider = FALSE,
        completionItemResolve = FALSE,
        definitionProvider = FALSE,
        referencesProvider = FALSE,
        documentHighlightProvider = FALSE,
        documentSymbolProvider = FALSE,

        # Use tree-sitter
        semanticTokensProvider = FALSE,
        foldingRangeProvider = FALSE,

        # Use air (conform plugin)
        documentFormattingProvider = FALSE,
        documentRangeFormattingProvider = FALSE,
        documentOnTypeFormattingProvider = FALSE,

        # Are these useful?
        documentLinkProvider = FALSE, # links are clickable in WezTerm
        colorProvider = FALSE, # We don't need 657 color names
        workspaceSymbolProvider = FALSE,
        selectionRangeProvider = FALSE,
        callHierarchyProvider = FALSE,
        typeHierarchyProvider = FALSE,

        # Use the languageserver
        codeActionProvider = TRUE,
        renameProvider = TRUE
    )
)

From all languageserver features, there are four that I don't know if are useful for us, and two that I recognize as useful.

For diagnostics, it seems that jarl is better than lintr.

[PMassicotte]

I am also working on the workspaceSymbols and the rename functionalities. Should be able to PR them this week.