one more attempt

Author: Jutho

src/pullbacks/lq.jl

@@ -4,6 +4,7 @@ function check_lq_cotangents(
         L, Q, ΔL, ΔQ, p::Int;
         gauge_atol::Real = default_pullback_gauge_atol(ΔQ)
     )
+    # check_qr_cotangents(Q', L', ΔQ', ΔL', p; gauge_atol)
     minmn = min(size(L, 1), size(Q, 2))
     Δgauge = abs(zero(eltype(Q)))
     if !iszerotangent(ΔQ)
@@ -19,6 +20,7 @@ function check_lq_cotangents(
     if !iszerotangent(ΔL)
         ΔL22 = view(ΔL, (p + 1):size(ΔL, 1), (p + 1):minmn)
         Δgauge_L = norm(view(ΔL22, lowertriangularind(ΔL22)), Inf)
+        Δgauge_L = max(Δgauge_L, norm(view(ΔL22, diagind(ΔL22)), Inf))
         Δgauge = max(Δgauge, Δgauge_L)
     end
     Δgauge ≤ gauge_atol ||

src/pullbacks/qr.jl

@@ -20,6 +20,7 @@ function check_qr_cotangents(
     if !iszerotangent(ΔR)
         ΔR22 = view(ΔR, (p + 1):minmn, (p + 1):size(R, 2))
         Δgauge_R = norm(view(ΔR22, uppertriangularind(ΔR22)), Inf)
+        Δgauge_R = max(Δgauge_R, norm(view(ΔR22, diagind(ΔR22)), Inf))
         Δgauge = max(Δgauge, Δgauge_R)
     end
     Δgauge ≤ gauge_atol ||

test/mooncake/eig.jl

@@ -12,7 +12,7 @@ is_buildkite = get(ENV, "BUILDKITE", "false") == "true"
 
 m = 19
 for T in (BLASFloats..., GenericFloats...)
-    TestSuite.seed_rng!(123)
+    TestSuite.seed_rng!(1234)
     if !is_buildkite
         TestSuite.test_mooncake_eig(T, (m, m); atol = m * m * TestSuite.precision(T), rtol = m * m * TestSuite.precision(T))
     end

test/mooncake/eigh.jl

@@ -12,7 +12,7 @@ is_buildkite = get(ENV, "BUILDKITE", "false") == "true"
 
 m = 19
 for T in (BLASFloats..., GenericFloats...)
-    TestSuite.seed_rng!(123)
+    TestSuite.seed_rng!(1234)
     if !is_buildkite
         TestSuite.test_mooncake_eigh(T, (m, m); atol = m * m * TestSuite.precision(T), rtol = m * m * TestSuite.precision(T))
     end

test/mooncake/lq.jl

@@ -3,7 +3,7 @@ using Test
 using LinearAlgebra: Diagonal
 using CUDA, AMDGPU
 
-BLASFloats = (Float32, ComplexF64) # full suite is too expensive on CI
+BLASFloats = (Float64, ComplexF64) # full suite is too expensive on CI
 GenericFloats = ()
 @isdefined(TestSuite) || include("../testsuite/TestSuite.jl")
 using .TestSuite
@@ -12,7 +12,7 @@ is_buildkite = get(ENV, "BUILDKITE", "false") == "true"
 
 m = 19
 for T in (BLASFloats..., GenericFloats...), n in (17, m, 23)
-    TestSuite.seed_rng!(123)
+    TestSuite.seed_rng!(1234)
     if !is_buildkite
         TestSuite.test_mooncake_lq(T, (m, n); atol = m * n * TestSuite.precision(T), rtol = m * n * TestSuite.precision(T))
     end

test/mooncake/orthnull.jl

@@ -12,7 +12,7 @@ is_buildkite = get(ENV, "BUILDKITE", "false") == "true"
 
 m = 19
 for T in (BLASFloats..., GenericFloats...), n in (17, m, 23)
-    TestSuite.seed_rng!(123)
+    TestSuite.seed_rng!(1234)
     if !is_buildkite
         TestSuite.test_mooncake_orthnull(T, (m, n); atol = m * n * TestSuite.precision(T), rtol = m * n * TestSuite.precision(T))
     end

test/mooncake/polar.jl

@@ -12,7 +12,7 @@ is_buildkite = get(ENV, "BUILDKITE", "false") == "true"
 
 m = 19
 for T in (BLASFloats..., GenericFloats...), n in (17, m, 23)
-    TestSuite.seed_rng!(123)
+    TestSuite.seed_rng!(1234)
     if !is_buildkite
         atol = rtol = m * n * TestSuite.precision(T)
         m >= n && TestSuite.test_mooncake_left_polar(T, (m, n); atol, rtol)

test/mooncake/qr.jl

@@ -3,7 +3,7 @@ using Test
 using LinearAlgebra: Diagonal
 using CUDA, AMDGPU
 
-BLASFloats = (Float32, ComplexF64) # full suite is too expensive on CI
+BLASFloats = (Float64, ComplexF64) # full suite is too expensive on CI
 GenericFloats = ()
 @isdefined(TestSuite) || include("../testsuite/TestSuite.jl")
 using .TestSuite
@@ -12,7 +12,7 @@ is_buildkite = get(ENV, "BUILDKITE", "false") == "true"
 
 m = 19
 for T in (BLASFloats..., GenericFloats...), n in (17, m, 23)
-    TestSuite.seed_rng!(123)
+    TestSuite.seed_rng!(1234)
     if !is_buildkite
         TestSuite.test_mooncake_qr(T, (m, n); atol = m * n * TestSuite.precision(T), rtol = m * n * TestSuite.precision(T))
     end

test/mooncake/svd.jl

@@ -12,7 +12,7 @@ is_buildkite = get(ENV, "BUILDKITE", "false") == "true"
 
 m = 19
 for T in (BLASFloats..., GenericFloats...), n in (17, m, 23)
-    TestSuite.seed_rng!(123)
+    TestSuite.seed_rng!(1234)
     if !is_buildkite
         TestSuite.test_mooncake_svd(T, (m, n); atol = m * n * TestSuite.precision(T), rtol = m * n * TestSuite.precision(T))
     end

test/testsuite/ad_utils.jl

@@ -86,6 +86,7 @@ function remove_qr_gauge_dependence!(ΔQ, ΔR, A, Q, R; rank_atol = MatrixAlgebr
     Q₁ᴴΔQ₃ = Q₁' * ΔQ₃
     mul!(ΔQ₃, Q₁, Q₁ᴴΔQ₃)
     ΔR22 = view(ΔR, (r + 1):minmn, (r + 1):size(R, 2))
+    MatrixAlgebraKit.diagview(ΔR22) .= 0
     view(ΔR22, MatrixAlgebraKit.uppertriangularind(ΔR22)) .= 0
     return ΔQ, ΔR
 end
@@ -120,6 +121,7 @@ function remove_lq_gauge_dependence!(ΔL, ΔQ, A, L, Q; rank_atol = MatrixAlgebr
     ΔQ₃Q₁ᴴ = ΔQ₃ * Q₁'
     mul!(ΔQ₃, ΔQ₃Q₁ᴴ, Q₁)
     ΔL22 = view(ΔL, (r + 1):size(ΔL, 1), (r + 1):minmn)
+    MatrixAlgebraKit.diagview(ΔL22) .= 0
     view(ΔL22, MatrixAlgebraKit.lowertriangularind(ΔL22)) .= 0
     return ΔL, ΔQ
 end