Remove Py.AllowThreads due to performance degradation (#108)

Martin-Molinero · web-flow · commit 223d1bef36f3 · 2025-10-21T11:02:17.000-03:00
* Remove AllowThreads call causing performance hit

* Bump to 2.0.49
diff --git a/src/perf_tests/Python.PerformanceTests.csproj b/src/perf_tests/Python.PerformanceTests.csproj
@@ -13,7 +13,7 @@
       <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
     </PackageReference>
     <PackageReference Include="Microsoft.NET.Test.Sdk" Version="16.*" />
-    <PackageReference Include="quantconnect.pythonnet" Version="2.0.48" GeneratePathProperty="true">
+    <PackageReference Include="quantconnect.pythonnet" Version="2.0.49" GeneratePathProperty="true">
       <IncludeAssets>compile</IncludeAssets>
     </PackageReference>
   </ItemGroup>
@@ -25,7 +25,7 @@
   </Target>
 
   <Target Name="CopyBaseline" AfterTargets="Build">
-    <Copy SourceFiles="$(NuGetPackageRoot)quantconnect.pythonnet\2.0.48\lib\net9.0\Python.Runtime.dll" DestinationFolder="$(OutDir)baseline" />
+    <Copy SourceFiles="$(NuGetPackageRoot)quantconnect.pythonnet\2.0.49\lib\net9.0\Python.Runtime.dll" DestinationFolder="$(OutDir)baseline" />
   </Target>
 
   <Target Name="CopyNewBuild" AfterTargets="Build">
diff --git a/src/runtime/Properties/AssemblyInfo.cs b/src/runtime/Properties/AssemblyInfo.cs
@@ -4,5 +4,5 @@
 [assembly: InternalsVisibleTo("Python.EmbeddingTest, PublicKey=00240000048000009400000006020000002400005253413100040000110000005ffd8f49fb44ab0641b3fd8d55e749f716e6dd901032295db641eb98ee46063cbe0d4a1d121ef0bc2af95f8a7438d7a80a3531316e6b75c2dae92fb05a99f03bf7e0c03980e1c3cfb74ba690aca2f3339ef329313bcc5dccced125a4ffdc4531dcef914602cd5878dc5fbb4d4c73ddfbc133f840231343e013762884d6143189")]
 [assembly: InternalsVisibleTo("Python.Test, PublicKey=00240000048000009400000006020000002400005253413100040000110000005ffd8f49fb44ab0641b3fd8d55e749f716e6dd901032295db641eb98ee46063cbe0d4a1d121ef0bc2af95f8a7438d7a80a3531316e6b75c2dae92fb05a99f03bf7e0c03980e1c3cfb74ba690aca2f3339ef329313bcc5dccced125a4ffdc4531dcef914602cd5878dc5fbb4d4c73ddfbc133f840231343e013762884d6143189")]
 
-[assembly: AssemblyVersion("2.0.48")]
-[assembly: AssemblyFileVersion("2.0.48")]
+[assembly: AssemblyVersion("2.0.49")]
+[assembly: AssemblyFileVersion("2.0.49")]
diff --git a/src/runtime/Python.Runtime.csproj b/src/runtime/Python.Runtime.csproj
@@ -5,7 +5,7 @@
     <RootNamespace>Python.Runtime</RootNamespace>
     <AssemblyName>Python.Runtime</AssemblyName>
     <PackageId>QuantConnect.pythonnet</PackageId>
-    <Version>2.0.48</Version>
+    <Version>2.0.49</Version>
     <GenerateAssemblyInfo>false</GenerateAssemblyInfo>
     <PackageLicenseFile>LICENSE</PackageLicenseFile>
     <RepositoryUrl>https://github.com/pythonnet/pythonnet</RepositoryUrl>
diff --git a/src/runtime/Types/FieldObject.cs b/src/runtime/Types/FieldObject.cs
@@ -64,18 +64,12 @@ public static NewReference tp_descr_get(BorrowedReference ds, BorrowedReference
                     // Fasterflect does not support constant fields
                     if (info.IsLiteral && !info.IsInitOnly)
                     {
-                        using (Py.AllowThreads())
-                        {
-                            result = info.GetValue(null);
-                        }
+                        result = info.GetValue(null);
                     }
                     else
                     {
                         var getter = self.GetMemberGetter(info.DeclaringType);
-                        using (Py.AllowThreads())
-                        {
-                            result = getter(info.DeclaringType);
-                        }
+                        result = getter(info.DeclaringType);
                     }
 
                     return Converter.ToPython(result, info.FieldType);
@@ -99,20 +93,14 @@ public static NewReference tp_descr_get(BorrowedReference ds, BorrowedReference
                 // Fasterflect does not support constant fields
                 if (info.IsLiteral && !info.IsInitOnly)
                 {
-                    using (Py.AllowThreads())
-                    {
-                        result = info.GetValue(co.inst);
-                    }
+                    result = info.GetValue(co.inst);
                 }
                 else
                 {
                     var type = co.inst.GetType();
                     var getter = self.GetMemberGetter(type);
                     var argument = self.IsValueType(type) ? co.inst.WrapIfValueType() : co.inst;
-                    using (Py.AllowThreads())
-                    {
-                        result = getter(argument);
-                    }
+                    result = getter(argument);
                 }
 
                 return Converter.ToPython(result, info.FieldType);
diff --git a/src/runtime/Types/PropertyObject.cs b/src/runtime/Types/PropertyObject.cs
@@ -77,10 +77,7 @@ public static NewReference tp_descr_get(BorrowedReference ds, BorrowedReference
                 try
                 {
                     var getterFunc = self.GetMemberGetter(info.DeclaringType);
-                    using (Py.AllowThreads())
-                    {
-                        result = getterFunc(info.DeclaringType);
-                    }
+                    result = getterFunc(info.DeclaringType);
                     return Converter.ToPython(result, info.PropertyType);
                 }
                 catch (Exception e)
@@ -97,10 +94,7 @@ public static NewReference tp_descr_get(BorrowedReference ds, BorrowedReference
 
             try
             {
-                using (Py.AllowThreads())
-                {
-                    result = getter.Invoke(co.inst, Array.Empty<object>());
-                }
+                result = getter.Invoke(co.inst, Array.Empty<object>());
                 return Converter.ToPython(result, info.PropertyType);
             }
             catch (Exception e)

Original file line number	Diff line number	Diff line change
`@@ -64,18 +64,12 @@ public static NewReference tp_descr_get(BorrowedReference ds, BorrowedReference`
`64`	`64`	`// Fasterflect does not support constant fields`
`65`	`65`	`if (info.IsLiteral && !info.IsInitOnly)`
`66`	`66`	`{`
`67`		`- using (Py.AllowThreads())`
`68`		`- {`
`69`		`- result = info.GetValue(null);`
`70`		`- }`
	`67`	`+ result = info.GetValue(null);`
`71`	`68`	`}`
`72`	`69`	`else`
`73`	`70`	`{`
`74`	`71`	`var getter = self.GetMemberGetter(info.DeclaringType);`
`75`		`- using (Py.AllowThreads())`
`76`		`- {`
`77`		`- result = getter(info.DeclaringType);`
`78`		`- }`
	`72`	`+ result = getter(info.DeclaringType);`
`79`	`73`	`}`
`80`	`74`
`81`	`75`	`return Converter.ToPython(result, info.FieldType);`
`@@ -99,20 +93,14 @@ public static NewReference tp_descr_get(BorrowedReference ds, BorrowedReference`
`99`	`93`	`// Fasterflect does not support constant fields`
`100`	`94`	`if (info.IsLiteral && !info.IsInitOnly)`
`101`	`95`	`{`
`102`		`- using (Py.AllowThreads())`
`103`		`- {`
`104`		`- result = info.GetValue(co.inst);`
`105`		`- }`
	`96`	`+ result = info.GetValue(co.inst);`
`106`	`97`	`}`
`107`	`98`	`else`
`108`	`99`	`{`
`109`	`100`	`var type = co.inst.GetType();`
`110`	`101`	`var getter = self.GetMemberGetter(type);`
`111`	`102`	`var argument = self.IsValueType(type) ? co.inst.WrapIfValueType() : co.inst;`
`112`		`- using (Py.AllowThreads())`
`113`		`- {`
`114`		`- result = getter(argument);`
`115`		`- }`
	`103`	`+ result = getter(argument);`
`116`	`104`	`}`
`117`	`105`
`118`	`106`	`return Converter.ToPython(result, info.FieldType);`
Original file line number	Diff line number	Diff line change
`@@ -77,10 +77,7 @@ public static NewReference tp_descr_get(BorrowedReference ds, BorrowedReference`
`77`	`77`	`try`
`78`	`78`	`{`
`79`	`79`	`var getterFunc = self.GetMemberGetter(info.DeclaringType);`
`80`		`- using (Py.AllowThreads())`
`81`		`- {`
`82`		`- result = getterFunc(info.DeclaringType);`
`83`		`- }`
	`80`	`+ result = getterFunc(info.DeclaringType);`
`84`	`81`	`return Converter.ToPython(result, info.PropertyType);`
`85`	`82`	`}`
`86`	`83`	`catch (Exception e)`
`@@ -97,10 +94,7 @@ public static NewReference tp_descr_get(BorrowedReference ds, BorrowedReference`
`97`	`94`
`98`	`95`	`try`
`99`	`96`	`{`
`100`		`- using (Py.AllowThreads())`
`101`		`- {`
`102`		`- result = getter.Invoke(co.inst, Array.Empty<object>());`
`103`		`- }`
	`97`	`+ result = getter.Invoke(co.inst, Array.Empty<object>());`
`104`	`98`	`return Converter.ToPython(result, info.PropertyType);`
`105`	`99`	`}`
`106`	`100`	`catch (Exception e)`