Fix stubtest with mypy 18

timhoffm · timhoffm · commit 4dcf15212467 · 2025-09-14T22:36:20.000+02:00
Closes matplotlib#30551 by disabling checks for disjoint bases. There may be other solutions like decorating Container and dviread.Text with @disjoint_base, however I've not yet fully understood whether that'd be technically correct. We have survived without disjoint bases checks so far, so at least a a quick fix this should good enough.
diff --git a/tools/stubtest.py b/tools/stubtest.py
@@ -108,6 +108,7 @@ def visit_ClassDef(self, node):
         [
             "stubtest",
             "--mypy-config-file=pyproject.toml",
+            "--ignore-disjoint-bases",
             "--allowlist=ci/mypy-stubtest-allowlist.txt",
             f"--allowlist={p}",
             "matplotlib",

Original file line number	Diff line number	Diff line change
`@@ -108,6 +108,7 @@ def visit_ClassDef(self, node):`
`108`	`108`	`[`
`109`	`109`	`"stubtest",`
`110`	`110`	`"--mypy-config-file=pyproject.toml",`
	`111`	`+ "--ignore-disjoint-bases",`
`111`	`112`	`"--allowlist=ci/mypy-stubtest-allowlist.txt",`
`112`	`113`	`f"--allowlist={p}",`
`113`	`114`	`"matplotlib",`