Commit 117d1db
committed
Revert renaming labels to tick_labels in boxplot_stats()
This is up for debate: I'm only +0.2 here.
The renaming was done in matplotlib#27901, which renamed the parameter `labels`
to `tick_labels` for `boxplot()` and `bxp()`.
One can take two views here:
- If `boxplot_stats()` is specifically for the input of `bxp()`, one
can justify the renaming as being consistent with the `bxp()`
signature. Note however, that the returned dict still
contains the key "label" for back-compatibility. So that brings us
an inconsistency between the parameter name and the returned dict key.
- One can alternatively view `boxplot_stats()` as a generic function to
define box parameters. Here, we'd only have a general `label` for
the boy and no information that this should be used as tick
label.
If we could make a clean transition and also rename the dict key, I
would tend to go with the first view. But the inevitable inconsistency
of the fist view let's me sway towards the second view, so that with
the revert, we've effectively not touched `boxplot_stats()`.1 parent 1c4c9af commit 117d1db
File tree
5 files changed
+12
-18
lines changed- galleries/examples/statistics
- lib/matplotlib
- axes
- tests
5 files changed
+12
-18
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
25 | 25 | | |
26 | 26 | | |
27 | 27 | | |
28 | | - | |
| 28 | + | |
29 | 29 | | |
30 | 30 | | |
31 | 31 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4001 | 4001 | | |
4002 | 4002 | | |
4003 | 4003 | | |
4004 | | - | |
| 4004 | + | |
4005 | 4005 | | |
4006 | 4006 | | |
4007 | 4007 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1126 | 1126 | | |
1127 | 1127 | | |
1128 | 1128 | | |
1129 | | - | |
1130 | | - | |
1131 | | - | |
| 1129 | + | |
1132 | 1130 | | |
1133 | 1131 | | |
1134 | 1132 | | |
| |||
1162 | 1160 | | |
1163 | 1161 | | |
1164 | 1162 | | |
1165 | | - | |
| 1163 | + | |
1166 | 1164 | | |
1167 | 1165 | | |
1168 | 1166 | | |
1169 | | - | |
1170 | | - | |
1171 | | - | |
1172 | | - | |
1173 | 1167 | | |
1174 | 1168 | | |
1175 | 1169 | | |
| |||
1245 | 1239 | | |
1246 | 1240 | | |
1247 | 1241 | | |
1248 | | - | |
1249 | | - | |
1250 | | - | |
1251 | | - | |
| 1242 | + | |
| 1243 | + | |
| 1244 | + | |
| 1245 | + | |
1252 | 1246 | | |
1253 | 1247 | | |
1254 | | - | |
| 1248 | + | |
1255 | 1249 | | |
1256 | 1250 | | |
1257 | 1251 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
135 | 135 | | |
136 | 136 | | |
137 | 137 | | |
138 | | - | |
| 138 | + | |
139 | 139 | | |
140 | 140 | | |
141 | 141 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
147 | 147 | | |
148 | 148 | | |
149 | 149 | | |
150 | | - | |
| 150 | + | |
151 | 151 | | |
152 | 152 | | |
153 | 153 | | |
| |||
158 | 158 | | |
159 | 159 | | |
160 | 160 | | |
161 | | - | |
| 161 | + | |
162 | 162 | | |
163 | 163 | | |
164 | 164 | | |
| |||
0 commit comments