Skip to content

Commit 1af58d3

Browse files
committed
Updated TODO
1 parent ac5822c commit 1af58d3

File tree

2 files changed

+4
-7
lines changed

2 files changed

+4
-7
lines changed

TODO.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,10 +4,6 @@
44
- [ ] fcntl subject
55
- [ ] remove inet_ntop
66

7-
- [ ] Is is possible for client to send data whilst cgi is processing?
8-
- [ ] (Optional) Fix problem of no server response in case of connection being destructed due to timeout, in every case but especially if cgi is active
9-
- [ ] (Optional) Implement try_files or similar
10-
- [ ] (Does not occur anymore without having actively tried to fix it) Investigate random closing of program without any notice after sending a first request
117

128
- [x] Implement and fix chunked request trailer parsing
139
- [x] Figure out why resolving symlinks doesnt work
@@ -21,5 +17,9 @@
2117
- [x] Implement chunked transfer encoding (https://datatracker.ietf.org/doc/html/rfc2616#section-3.6
2218
&& https://datatracker.ietf.org/doc/html/rfc2616#section-19.4.6)
2319

20+
- [ ] <del>Is is possible for client to send data whilst cgi is processing?</del>
21+
- [ ] <del>(Optional) Fix problem of no server response in case of connection being destructed due to timeout, in every case but especially if cgi is active</del>
22+
- [ ] <del>(Optional) Implement try_files or similar</del>
23+
- [ ] <del>(Does not occur anymore without having actively tried to fix it) Investigate random closing of program without any notice after sending a first request</del>
2424
- [ ] <del>Maybe use streambufs instead of streams https://gcc.gnu.org/onlinedocs/libstdc++/manual/fstreams.html#std.io.filestreams.binary</del>
2525
- [ ] <del>Maybe implement configurable default mime</del>

src/http/Http.cpp

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -301,9 +301,6 @@ void Http::processCgi(std::string contentLength) {
301301
env.push_back("HTTP_COOKIE=" + _request.getHeaderField("Cookie"));
302302
env.push_back("HTTP_USER_AGENT=" + _request.getHeaderField("User-Agent"));
303303

304-
// env.push_back("PATH_INFO=" ...); // TODO: Implement
305-
// env.push_back("PATH_TRANSLATED=" ...);
306-
307304
runCGI(cgiProgramPathname, std::vector<std::string>(1, pathname), env);
308305
if (_request.isMethod("POST") == false) cgiCloseSendPipe();
309306
_response.clear();

0 commit comments

Comments
 (0)