refactor: Make V1TraitDataConverter an abstract base class, use a dedicated LedStatusConverter, and fix a typo in Rooms.

Author: allenporter

roborock/devices/traits/v1/common.py

@@ -18,7 +18,7 @@
 V1ResponseData = dict | list | int | str
 
 
-class V1TraitDataConverter:
+class V1TraitDataConverter(ABC):
     """Converts responses to RoborockBase objects.
 
     This is an internal class and should not be used directly by consumers.

roborock/devices/traits/v1/device_features.py

@@ -18,7 +18,7 @@ def __init__(self, product: HomeDataProduct) -> None:
     def convert(self, response: common.V1ResponseData) -> DeviceFeatures:
         """Parse the response from the device into a MapContentTrait instance."""
         if not isinstance(response, list):
-            raise ValueError(f"Unexpected AppInitStatus response format: {type(response)}")
+            raise ValueError(f"Unexpected AppInitStatus response format: {type(response)}: {response!r}")
         app_status = AppInitStatus.from_dict(response[0])
         return DeviceFeatures.from_feature_flags(
             new_feature_info=app_status.new_feature_info,

roborock/devices/traits/v1/led_status.py

@@ -26,7 +26,7 @@ class LedStatusTrait(LedStatus, common.V1TraitMixin, common.RoborockSwitchBase):
     """Trait for controlling the LED status of a Roborock device."""
 
     command = RoborockCommand.GET_LED_STATUS
-    converter = common.DefaultConverter(LedStatus)
+    converter = LedStatusConverter()
     requires_feature = "is_led_status_switch_supported"
 
     @property

roborock/devices/traits/v1/rooms.py

@@ -25,7 +25,7 @@ def room_map(self) -> dict[int, NamedRoomMapping]:
             return {}
         return {room.segment_id: room for room in self.rooms}
 
-    def with_rooom_names(self, name_map: dict[str, str]) -> "Rooms":
+    def with_room_names(self, name_map: dict[str, str]) -> "Rooms":
         """Create a new Rooms object with updated room names."""
         return Rooms(
             rooms=[
@@ -102,7 +102,7 @@ async def refresh(self) -> None:
         segment_map = self.converter.extract_segment_map(response)
         await self._populate_missing_home_data_rooms(segment_map)
         rooms = self.converter.convert(response)
-        rooms = rooms.with_rooom_names(self._iot_id_room_name_map)
+        rooms = rooms.with_room_names(self._iot_id_room_name_map)
         common.merge_trait_values(self, rooms)
 
     @property