refactor(YXCleanType): simplify clean type definitions and remove legacy alias support

Author: lboue

roborock/data/b01_q10/b01_q10_code_mappings.py

@@ -1,5 +1,3 @@
-from typing import Self
-
 from ..code_mappings import RoborockModeEnum
 
 
@@ -157,29 +155,11 @@ class YXRoomMaterial(RoborockModeEnum):
     OTHER = "other", 255
 
 
-_YX_CLEAN_TYPE_LEGACY_VALUES: dict[str, str] = {
-    "bothwork": "vac_and_mop",
-    "onlysweep": "vacuum",
-    "onlymop": "mop",
-}
-
-
 class YXCleanType(RoborockModeEnum):
     UNKNOWN = "unknown", -1
-    VAC_AND_MOP = "vac_and_mop", 1
-    VACUUM = "vacuum", 2
-    MOP = "mop", 3
-
-    # Legacy aliases
-    BOTH_WORK = VAC_AND_MOP
-    ONLY_SWEEP = VACUUM
-    ONLY_MOP = MOP
-
-    @classmethod
-    def from_value(cls, value: str) -> Self:
-        """Find enum member by string value with legacy support."""
-        normalized_value = _YX_CLEAN_TYPE_LEGACY_VALUES.get(value.lower(), value)
-        return super().from_value(normalized_value)
+    VAC_AND_MOP = "vac_and_mop", 1  # bothwork
+    VACUUM = "vacuum", 2  # onlysweep
+    MOP = "mop", 3  # onlymop
 
 
 class YXDeviceState(RoborockModeEnum):

tests/data/test_code_mappings.py

@@ -5,7 +5,7 @@
 import pytest
 
 from roborock import HomeDataProduct, RoborockCategory
-from roborock.data.b01_q10.b01_q10_code_mappings import B01_Q10_DP, YXCleanType
+from roborock.data.b01_q10.b01_q10_code_mappings import B01_Q10_DP
 
 
 def test_from_code() -> None:
@@ -52,22 +52,6 @@ def test_invalid_from_value() -> None:
         B01_Q10_DP.from_value("invalid_value")
 
 
-@pytest.mark.parametrize(
-    ("raw_value", "expected"),
-    [
-        ("bothwork", YXCleanType.VAC_AND_MOP),
-        ("onlysweep", YXCleanType.VACUUM),
-        ("onlymop", YXCleanType.MOP),
-        ("BothWork", YXCleanType.VAC_AND_MOP),
-        ("ONLYSWEEP", YXCleanType.VACUUM),
-        ("OnlyMop", YXCleanType.MOP),
-    ],
-)
-def test_yxcleantype_from_value_legacy_aliases(raw_value: str, expected: YXCleanType) -> None:
-    """Ensure legacy clean type strings resolve to canonical enum members."""
-    assert YXCleanType.from_value(raw_value) is expected
-
-
 @pytest.mark.parametrize(
     "input, expected",
     [