fix: Additional device logging improvements (#668)

* fix: Improve device logging

The logging chnages include:
(1) Log less of HomeData since it is large, and instead log a short TL;Dr for each device to make it easier to read. We will rely more on diagnostics for this (though this also needs some changes to get there)
(2) Remove redudundant local connection logging (done both in v1 channel and local channel)
(3) Fix some additional cases not using the device logger
(4) Remove an unncessary line that says "Connecting to device" after it has already connected

* chore: further readability improvements to device logging

* chore: improve device logging container summary string

Author: allenporter

roborock/data/containers.py

@@ -228,6 +228,10 @@ class HomeDataProduct(RoborockBase):
     def product_nickname(self) -> RoborockProductNickname:
         return SHORT_MODEL_TO_ENUM.get(self.model.split(".")[-1], RoborockProductNickname.PEARLPLUS)
 
+    def summary_info(self) -> str:
+        """Return a string with key product information for logging purposes."""
+        return f"{self.name} (model={self.model}, category={self.category})"
+
 
 @dataclass
 class HomeDataDevice(RoborockBase):
@@ -263,6 +267,10 @@ class HomeDataDevice(RoborockBase):
     share_type: Any | None = None
     share_expired_time: int | None = None
 
+    def summary_info(self) -> str:
+        """Return a string with key device information for logging purposes."""
+        return f"{self.name} (pv={self.pv}, fv={self.fv}, online={self.online})"
+
 
 @dataclass
 class HomeDataRoom(RoborockBase):

roborock/devices/device.py

@@ -183,7 +183,6 @@ async def connect(self) -> None:
         if self._unsub:
             raise ValueError("Already connected to the device")
         unsub = await self._channel.subscribe(self._on_message)
-        self._logger.info("Connecting to device")
         if self.v1_properties is not None:
             try:
                 await self.v1_properties.discover_features()

roborock/devices/device_manager.py

@@ -78,12 +78,13 @@ async def discover_devices(self) -> list[RoborockDevice]:
         home_data = cache_data.home_data
 
         device_products = home_data.device_products
-        _LOGGER.debug("Discovered %d devices %s", len(device_products), home_data)
+        _LOGGER.debug("Discovered %d devices", len(device_products))
 
         # These are connected serially to avoid overwhelming the MQTT broker
         new_devices = {}
         start_tasks = []
         for duid, (device, product) in device_products.items():
+            _LOGGER.debug("[%s] Discovered device %s %s", duid, product.summary_info(), device.summary_info())
             if duid in self._devices:
                 continue
             new_device = self._device_creator(home_data, device, product)

roborock/devices/local_channel.py

@@ -179,7 +179,6 @@ async def connect(self) -> None:
         if self._is_connected:
             self._logger.debug("Unexpected call to connect when already connected")
             return
-        self._logger.debug("Connecting to %s:%s", self._host, _PORT)
         loop = asyncio.get_running_loop()
         protocol = _LocalProtocol(self._data_received, self._connection_lost)
         try:

roborock/devices/v1_channel.py

@@ -373,7 +373,7 @@ async def _local_connect(self, *, prefer_cache: bool = True) -> None:
         # Wire up the new channel
         self._local_channel = local_channel
         self._local_unsub = await self._local_channel.subscribe(self._on_local_message)
-        _LOGGER.info("Successfully connected to local device %s", self._device_uid)
+        self._logger.info("Connected to local channel successfully")
 
     async def _background_reconnect(self) -> None:
         """Task to run in the background to manage the local connection."""