fix: adjust cache implementation defaults

Author: allenporter

roborock/devices/cache.py

@@ -45,3 +45,13 @@ async def get(self) -> CacheData:
 
     async def set(self, value: CacheData) -> None:
         self._data = value
+
+
+class NoCache(Cache):
+    """No-op cache implementation."""
+
+    async def get(self) -> CacheData:
+        return CacheData()
+
+    async def set(self, value: CacheData) -> None:
+        pass

roborock/devices/device_manager.py

@@ -18,7 +18,7 @@
 from roborock.protocol import create_mqtt_params
 from roborock.web_api import RoborockApiClient
 
-from .cache import Cache, InMemoryCache
+from .cache import Cache, NoCache
 from .channel import Channel
 from .mqtt_channel import create_mqtt_channel
 from .traits.dyad import DyadApi
@@ -137,7 +137,7 @@ async def create_device_manager(
     include caching or other optimizations.
     """
     if cache is None:
-        cache = InMemoryCache()
+        cache = NoCache()
 
     mqtt_params = create_mqtt_params(user_data.rriot)
     mqtt_session = await create_mqtt_session(mqtt_params)

tests/devices/test_device_manager.py

@@ -6,6 +6,7 @@
 import pytest
 
 from roborock.containers import HomeData, UserData
+from roborock.devices.cache import CacheData, InMemoryCache
 from roborock.devices.device_manager import create_device_manager, create_home_data_api
 from roborock.exceptions import RoborockException
 
@@ -109,9 +110,6 @@ async def mock_home_data_with_counter() -> HomeData:
         call_count += 1
         return HomeData.from_dict(mock_data.HOME_DATA_RAW)
 
-    # Create a real cache implementation for testing
-    from roborock.devices.cache import CacheData
-
     class TestCache:
         def __init__(self):
             self._data = CacheData()
@@ -122,9 +120,8 @@ async def get(self) -> CacheData:
         async def set(self, value: CacheData) -> None:
             self._data = value
 
-    cache = TestCache()
     # First call happens during create_device_manager initialization
-    device_manager = await create_device_manager(USER_DATA, mock_home_data_with_counter, cache)
+    device_manager = await create_device_manager(USER_DATA, mock_home_data_with_counter, cache=InMemoryCache())
     assert call_count == 1
 
     # Second call should use cache, not increment call_count