Skip to content

Commit 352a0b3

Browse files
committed
chore: add back test case and add test ids
1 parent 0a40a7b commit 352a0b3

File tree

1 file changed

+6
-4
lines changed

1 file changed

+6
-4
lines changed

tests/devices/test_v1_channel.py

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -355,13 +355,15 @@ async def test_v1_channel_send_command_local_fails(
355355
@pytest.mark.parametrize(
356356
("local_channel_side_effect", "local_channel_responses", "mock_mqtt_channel_responses"),
357357
[
358-
# Local fails immediately, MQTT succeeds
359358
(RoborockException("Local failed"), [], [TEST_RESPONSE]),
360-
# Local returns no response, MQTT succeeds
361359
(None, [], [TEST_RESPONSE]),
362-
# Local returns invalid response, MQTT succeeds
363-
# (None, [RoborockMessage(protocol=RoborockMessageProtocol.RPC_RESPONSE, payload=b"invalid")], [TEST_RESPONSE]),
360+
(None, [RoborockMessage(protocol=RoborockMessageProtocol.RPC_RESPONSE, payload=b"invalid")], [TEST_RESPONSE]),
364361
],
362+
ids=[
363+
"local-fails-mqtt-succeeds",
364+
"local-no-response-mqtt-succeeds",
365+
"local-invalid-response-mqtt-succeeds",
366+
]
365367
)
366368
async def test_v1_channel_send_pick_first_available(
367369
v1_channel: V1Channel,

0 commit comments

Comments
 (0)