feat: Update tests with additional feedback

Author: allenporter

roborock/devices/device.py

@@ -53,9 +53,9 @@ def device_version(self) -> str:
         and used as a placeholder for upcoming functionality for devices that will behave
         differently based on the version and capabilities.
         """
-        if self._device_info.pv == "1.0":
+        if self._device_info.pv == DeviceVersion.V1.value:
             return DeviceVersion.V1
-        elif self._device_info.pv in ["A1", "A01"]:
+        elif self._device_info.pv == DeviceVersion.A01.value:
             return DeviceVersion.A01
         _LOGGER.warning(
             "Unknown device version %s for device %s, using default UNKNOWN",

tests/devices/test_device_manager.py

@@ -41,9 +41,11 @@ async def test_with_device() -> None:
     """Test the DeviceManager created with devices returned from the API."""
     device_manager = await create_device_manager(USER_DATA, mock_home_data)
     devices = await device_manager.get_devices()
-    assert [(device.duid, device.name, device.device_version) for device in devices] == [
-        ("abc123", "Roborock S7 MaxV", DeviceVersion.V1),
-    ]
+    assert len(devices) == 1
+    device = devices[0]
+    assert device.duid == "abc123"
+    assert device.name == "Roborock S7 MaxV"
+    assert device.device_version == DeviceVersion.V1
 
     device = await device_manager.get_device("abc123")
     assert device is not None

tests/test_containers.py

@@ -78,7 +78,7 @@ def test_home_data():
     assert device.runtime_env is None
     assert device.time_zone_id == "America/Los_Angeles"
     assert device.icon_url == "no_url"
-    assert device.product_id == "product123"
+    assert device.product_id == "product-id-123"
     assert device.lon is None
     assert device.lat is None
     assert not device.share