Merge pull request #268 from azmeuk/trim-options

Strip option text

Author: gawel

CHANGELOG.rst

@@ -4,7 +4,7 @@ News
 3.0.5 (unreleased)
 ------------------
 
-- Nothing changed yet.
+- Strip ``<option>`` text.
 
 
 3.0.4 (2025-02-03)

tests/html/form_inputs.html

@@ -5,7 +5,9 @@
             <select name="select">
                 <option value="value1">Value 1</option>
                 <option value="value2" selected>Value 2</option>
-                <option value="value3">Value 3</option>
+                <option value="value3">
+                    Value 3
+                </option>
             </select>
             <input type="file" name="file" />
             <input type="unknown" name="unknown" />

tests/test_forms.py

@@ -63,6 +63,12 @@ def test_force_select(self):
 
     def test_form_select(self):
         form = self.callFUT()
+
+        self.assertEqual(form['select'].options, [
+            ('value1', False, 'Value 1'),
+            ('value2', True, 'Value 2'),
+            ('value3', False, 'Value 3')
+        ])
         form.select('select', 'value1')
 
         self.assertEqual(

webtest/forms.py

@@ -501,7 +501,7 @@ def _form_elt_filter(tag):
                     field.options.append(
                         (option.attrs.get('value', option.text),
                          'selected' in option.attrs,
-                         option.text))
+                         option.text.strip()))
 
         self.field_order = field_order
         self.fields = fields