refactor(tests): pytest tmp_path instead of TMP_DIR

Author: Nigma-Ks

backend/file_utils/tests/test_file_utils.py

@@ -1,6 +1,6 @@
-import shutil
-
-import pytest, os, csv
+import pytest
+import os
+import csv
 
 from backend.config.paths import TMP_FILE_DIR
 from backend.file_utils.csv_methods_writer import write_launch_info_to_csv
@@ -13,7 +13,7 @@
 @pytest.mark.parametrize(
     "filepaths",
     [
-        ([TMP_FILE_DIR + "/test0"]),
+        ([TMP_FILE_DIR + "/test"]),
         ([TMP_FILE_DIR + "/test1", TMP_FILE_DIR + "/test2"]),
     ],
 )
@@ -25,37 +25,37 @@ def test_removing_tmp_files(filepaths):
         assert not os.path.exists(path)
 
 
-def test_save_upload_file():
+def test_save_upload_file(tmp_path):
     test_content = b"Hello, World!" * 1000
-    upload_dir = TMP_FILE_DIR + "/test_save_upload/"
-    dest_path = upload_dir + "test.txt"
+    dest_path = tmp_path / "test.txt"
 
     mock_file = BytesIO(test_content)
     upload_file = Mock(spec=UploadFile)
     upload_file.file = mock_file
 
-    save_upload_file(upload_file, dest_path)
+    save_upload_file(upload_file, str(dest_path))
 
-    assert os.path.exists(dest_path)
+    assert dest_path.exists()
     with open(dest_path, "rb") as f:
         saved_content = f.read()
-    shutil.rmtree(upload_dir)
+
     assert saved_content == test_content
 
 
-def test_write_launch_info_to_csv():
-    upload_dir = TMP_FILE_DIR + "/test_write_launch_info_to_csv/"
-    os.makedirs(upload_dir)
-    output_file = upload_dir + "launch_info.csv"
+def test_write_launch_info_to_csv(tmp_path):
+    output_file = tmp_path / "launch_info.csv"
+
     parsed_methods = [
         "ManuallyCollected.dll,BinSearchMain",
         "ManuallyCollected.dll,BellmanFord",
         "ManuallyCollected.dll,BinaryMaze1BFS",
     ]
 
-    write_launch_info_to_csv(parsed_methods=parsed_methods, output_file=output_file)
+    write_launch_info_to_csv(
+        parsed_methods=parsed_methods, output_file=str(output_file)
+    )
 
-    assert os.path.exists(output_file)
+    assert output_file.exists()
 
     with open(output_file, "r") as f:
         reader = csv.reader(f)
@@ -68,5 +68,5 @@ def test_write_launch_info_to_csv():
         ["ManuallyCollected.dll", "BellmanFord"],
         ["ManuallyCollected.dll", "BinaryMaze1BFS"],
     ]
-    shutil.rmtree(upload_dir)
+
     assert rows[1:] == expected_data

backend/launch_service/tests/test_setup_functions.py

@@ -1,17 +1,14 @@
 import os
-import shutil
 from unittest.mock import Mock, patch
 
-from backend.config.paths import TMP_FILE_DIR, DOCKER_DIR, RESOURCES_DIR
+from backend.config.paths import DOCKER_DIR, RESOURCES_DIR
 from backend.launch_service.app_setup import fetch_dataset, IMAGE_NAME, build_container
 
 
-def test_fetch_dataset():
+def test_fetch_dataset(tmp_path):
     url = "https://example.com/dataset.csv"
     test_content = b"dll,method\nManuallyCollected.dll,BinSearchMain"
-    upload_dir = TMP_FILE_DIR + "/test_dataset_upload/"
-    os.makedirs(upload_dir)
-    data_file = upload_dir + "dataset.json"
+    data_file = tmp_path / "dataset.json"
 
     with patch("requests.get") as mock_get:
         mock_response = Mock()
@@ -25,7 +22,6 @@ def test_fetch_dataset():
     assert os.path.exists(data_file)
     with open(data_file, "rb") as f:
         assert f.read() == test_content
-    shutil.rmtree(upload_dir)
     mock_get.assert_called_once_with(url)
     mock_response.raise_for_status.assert_called_once()