From 32937c6497c30e63d608f3c36e59156b53de34f2 Mon Sep 17 00:00:00 2001 From: WyattBlue Date: Thu, 22 Jan 2026 22:47:20 -0500 Subject: [PATCH] Make av.ArgumentError a subclass of ValueError Make av.ArgumentError a subclass of ValueError until the next major version (18.0). --- av/error.py | 2 +- tests/test_errors.py | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/av/error.py b/av/error.py index 8827aafc2..77fce88d1 100644 --- a/av/error.py +++ b/av/error.py @@ -290,7 +290,7 @@ def _extend_builtin(name, codes): _extend_builtin("OSError", [code for code in errno.errorcode if code not in classes]) -class ArgumentError(FFmpegError): +class ArgumentError(FFmpegError, ValueError): def __str__(self): msg = "" if self.strerror is not None: diff --git a/tests/test_errors.py b/tests/test_errors.py index 68e2681e1..fdfe0f49d 100644 --- a/tests/test_errors.py +++ b/tests/test_errors.py @@ -28,6 +28,8 @@ def test_stringify() -> None: def test_bases() -> None: assert issubclass(av.ArgumentError, av.FFmpegError) + # Deprecated, assert false for Major 18.0: + assert issubclass(av.ArgumentError, ValueError) assert issubclass(av.FileNotFoundError, FileNotFoundError) assert issubclass(av.FileNotFoundError, OSError) assert issubclass(av.FileNotFoundError, av.FFmpegError)