Skip to content

Commit 71986f7

Browse files
PureWeenCopilot
andcommitted
perf: remove redundant DiffParser.Parse in ChatMessageItem render
ShouldRenderDiffView already validates the content is a parseable unified diff. The extra Parse + Count > 0 guard in the render body was always true when _hasDiffOutput was set, making the else branch (fallback <pre>) dead code. DiffView internally parses via OnParametersSet, so the removed call was a wasted parse per render. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
1 parent 765698a commit 71986f7

1 file changed

Lines changed: 3 additions & 11 deletions

File tree

PolyPilot/Components/ChatMessageItem.razor

Lines changed: 3 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -233,17 +233,9 @@
233233
}
234234
else if (_hasDiffOutput)
235235
{
236-
var _parsedDiff = DiffParser.Parse(Message.Content);
237-
if (_parsedDiff.Count > 0)
238-
{
239-
<div class="action-output-diff">
240-
<DiffView RawDiff="@Message.Content" />
241-
</div>
242-
}
243-
else
244-
{
245-
<pre>@ChatMessageList.TruncateResult(Message.Content)</pre>
246-
}
236+
<div class="action-output-diff">
237+
<DiffView RawDiff="@Message.Content" />
238+
</div>
247239
}
248240
else if (DiffParser.TryExtractNumberedViewOutput(Message.Content, out var _plainViewOutput))
249241
{

0 commit comments

Comments
 (0)