fix(lint): resolve remaining eslint-plugin-unicorn@67 violations (526 manual)

Adopt unicorn 67 fully across container/lib/terminal/app (api had none).
All behavior-preserving:
- no-unsafe-string-replacement: wrap template placeholder substitutions in
  () => value arrow replacers (also avoids $-pattern interpretation)
- consistent-boolean-name: prefix booleans with is/has/can/should/did/was;
  wire/contract keys preserved, only local identifiers renamed
- max-nested-calls: extract innermost calls into named consts
- no-non-function-verb-prefix: rename non-function values to nouns
- prefer-await conflicts with the project's effect-ts no-async rule -> rewritten
  Effect-natively (Effect.ensuring/tap/tryPromise), no async/await introduced
- assorted: minimal-ternary, number-is-safe-integer, url-href, etc.

Verified: all packages build + typecheck + lint(0) + lint:effect + tests green
(container 66, terminal 150, lib 227, api 189, app 449).

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

Author: skulidropek

packages/app/src/docker-git/api-client-auth.ts

@@ -5,9 +5,9 @@ import { Effect } from "effect"
 import {
   authStreamMarkerExitCode,
   type AuthStreamMarkers,
-  authStreamSucceeded,
   codexLoginFailureMessage,
   codexLoginStreamMarkers,
+  didAuthStreamSucceed,
   githubLoginFailureMessage,
   githubLoginStreamMarkers,
   gitlabLoginFailureMessage,
@@ -62,14 +62,14 @@ const requestMarkedAuthStream = (
     const output = yield* _(requestTextStream("POST", path, body, writer.writeChunk))
     writer.flushVisiblePending()
 
-    if (authStreamSucceeded(output, markers)) {
+    if (didAuthStreamSucceed(output, markers)) {
       return output
     }
 
+    const exitCode = authStreamMarkerExitCode(output, markers)
+    const message = failureMessage(output, exitCode)
     return yield* _(
-      Effect.fail<ApiRequestError>(
-        streamFailure("POST", path, failureMessage(output, authStreamMarkerExitCode(output, markers)))
-      )
+      Effect.fail<ApiRequestError>(streamFailure("POST", path, message))
     )
   })
 

packages/app/src/docker-git/api-client-create.ts

@@ -25,9 +25,9 @@ export const buildCreateProjectRequest = (
     containerName: config.containerName,
     serviceName: config.serviceName,
     volumeName: config.volumeName,
-    authorizedKeysPath: resolvedPaths.authorizedKeysContents === undefined
-      ? resolvedPaths.authorizedKeysPath
-      : defaultTemplateConfig.authorizedKeysPath,
+    authorizedKeysPath: (resolvedPaths.authorizedKeysContents === undefined
+      ? resolvedPaths
+      : defaultTemplateConfig).authorizedKeysPath,
     authorizedKeysContents: resolvedPaths.authorizedKeysContents,
     envGlobalPath: config.envGlobalPath,
     envProjectPath: config.envProjectPath,

packages/app/src/docker-git/api-client-events.ts

@@ -206,15 +206,14 @@ export const waitForProjectCreation = (
 export const startProjectEventPolling = (projectId: string, initialCursor: number) =>
   Effect.gen(function*(_) {
     const cursorRef = yield* _(Ref.make(initialCursor))
+    const pollSchedule = Schedule.addDelay(
+      Schedule.forever,
+      () => projectEventPollInterval
+    )
     const fiber = yield* _(
       pollProjectEventsOnce(projectId, cursorRef).pipe(
         Effect.ignore,
-        Effect.repeat(
-          Schedule.addDelay(
-            Schedule.forever,
-            () => projectEventPollInterval
-          )
-        ),
+        Effect.repeat(pollSchedule),
         Effect.fork
       )
     )

packages/app/src/docker-git/api-client.ts

@@ -60,17 +60,15 @@ const projectPath = (projectId: string, suffix = ""): string => `/projects/${enc
 
 const decodeProjectResponse = (payload: JsonValue) => {
   const object = asObject(payload)
-  return object === null
-    ? decodeProjectDetails(payload)
-    : decodeProjectDetails(object["project"] ?? payload)
+  return decodeProjectDetails(object === null ? payload : object["project"] ?? payload)
 }
 
 const decodeProjectsResponse = <A>(
   payload: JsonValue,
   decode: (value: JsonValue) => A | null
 ): ReadonlyArray<A> => {
   const object = asObject(payload)
-  const items = object === null ? asArray(payload) : asArray(object["projects"])
+  const items = asArray(object === null ? payload : object["projects"])
   return items
     .map((item) => decode(item))
     .filter((value): value is A => value !== null)
@@ -93,8 +91,8 @@ const createProjectAsync = (
   resolvedPaths: ResolvedCreateRequestPaths
 ) =>
   Effect.gen(function*(_) {
-    const createRequest = buildCreateProjectRequest(command, resolvedPaths, { async: true })
-    const payload = yield* _(request("POST", "/projects", createRequest))
+    const requestBody = buildCreateProjectRequest(command, resolvedPaths, { async: true })
+    const payload = yield* _(request("POST", "/projects", requestBody))
     const accepted = decodeCreateProjectAccepted(payload)
     if (accepted === null) {
       return yield* _(Effect.fail(invalidCreateAcceptedResponse()))
@@ -141,8 +139,8 @@ const createProjectWithResolvedPaths = (
       return yield* _(createProjectAsync(command, resolvedPaths))
     }
 
-    const createRequest = buildCreateProjectRequest(command, resolvedPaths)
-    const projectId = asString(createRequest.outDir)
+    const requestBody = buildCreateProjectRequest(command, resolvedPaths)
+    const projectId = asString(requestBody.outDir)
     const initialCursor = projectId === null
       ? null
       : yield* _(
@@ -153,13 +151,12 @@ const createProjectWithResolvedPaths = (
     const eventPolling = projectId === null || initialCursor === null
       ? null
       : yield* _(startProjectEventPolling(projectId, initialCursor))
+    const ensureStopped = eventPolling === null
+      ? Effect.void
+      : stopProjectEventPolling(eventPolling)
     const payload = yield* _(
-      request("POST", "/projects", createRequest).pipe(
-        Effect.ensuring(
-          eventPolling === null
-            ? Effect.void
-            : stopProjectEventPolling(eventPolling)
-        )
+      request("POST", "/projects", requestBody).pipe(
+        Effect.ensuring(ensureStopped)
       )
     )
     return decodeProjectResponse(payload)
@@ -176,10 +173,9 @@ const withProjectEventPolling = <A, E, R>(
       )
     )
     const eventPolling = yield* _(startProjectEventPolling(projectId, initialCursor))
+    const ensureStopped = stopProjectEventPolling(eventPolling)
     return yield* _(
-      effect.pipe(
-        Effect.ensuring(stopProjectEventPolling(eventPolling))
-      )
+      effect.pipe(Effect.ensuring(ensureStopped))
     )
   })
 
@@ -236,8 +232,8 @@ export const readProjectLogs = (projectId: string) =>
     Effect.map((payload) => readProjectOutput(payload))
   )
 
-export const readContainerTaskSnapshot = (projectId: string, includeDefault: boolean) =>
-  request("GET", projectPath(projectId, `/tasks${includeDefault ? "?includeDefault=true" : ""}`)).pipe(
+export const readContainerTaskSnapshot = (projectId: string, shouldIncludeDefault: boolean) =>
+  request("GET", projectPath(projectId, `/tasks${shouldIncludeDefault ? "?includeDefault=true" : ""}`)).pipe(
     Effect.map((payload) => decodeContainerTaskSnapshot(payload))
   )
 
@@ -275,7 +271,8 @@ export const createAuthTerminalSession = (
 
 export const deleteTerminalSessionByPath = (path: string) => requestVoid("DELETE", path)
 
-export const applyAllProjects = (activeOnly: boolean) => requestVoid("POST", "/projects/apply-all", { activeOnly })
+export const applyAllProjects = (isActiveOnly: boolean) =>
+  requestVoid("POST", "/projects/apply-all", { activeOnly: isActiveOnly })
 
 export const downAllProjects = () => requestVoid("POST", "/projects/down-all")
 

packages/app/src/docker-git/api-json.ts

@@ -43,11 +43,12 @@ export const asString = (value: JsonValue | undefined): string | null => typeof
 const renderGithubStatusLine = (entry: JsonObject): string | null => {
   const label = asString(entry["label"])
   const status = asString(entry["status"])
-  const login = asString(entry["login"])
   if (label === null || status === null) {
     return null
   }
 
+  const login = asString(entry["login"])
+
   if (status === "valid") {
     return login === null
       ? `- ${label}: valid (owner unavailable)`

packages/app/src/docker-git/browser-frontend.ts

@@ -390,7 +390,7 @@ export const runBrowserFrontendCommandWithOptions = (
       if (!decision.shouldStartWeb) {
         return Effect.log(`docker-git browser frontend is already running at http://${decision.host}:${decision.port}/`)
       }
-      return options.daemon ? runBrowserFrontendDaemon(decision) : runBrowserFrontend(decision)
+      return (options.daemon ? runBrowserFrontendDaemon : runBrowserFrontend)(decision)
     })
   )
 

packages/app/src/docker-git/cli/parser-scrap.ts

@@ -48,13 +48,13 @@ const makeScrapExportCommand = (projectDir: string, archivePath: string, mode: "
 const makeScrapImportCommand = (
   projectDir: string,
   archivePath: string,
-  wipe: boolean,
+  shouldWipe: boolean,
   mode: "session"
 ): Command => ({
   _tag: "ScrapImport",
   projectDir,
   archivePath,
-  wipe,
+  wipe: shouldWipe,
   mode
 })
 

packages/app/src/docker-git/cli/parser-shared.ts

@@ -62,7 +62,7 @@ export const parsePositiveInt = (
   option: string,
   raw: string
 ): Either.Either<number, ParseError> => {
-  const value = Number.parseInt(raw, 10)
+  const value = Math.trunc(Number(raw))
   if (!Number.isFinite(value) || value <= 0) {
     const error: ParseError = {
       _tag: "InvalidOption",

packages/app/src/docker-git/controller-docker-diagnostics.ts

@@ -17,7 +17,7 @@ export type DockerProbeOutcome = {
 
 const lowercase = (text: string): string => text.toLowerCase()
 
-const containsAny = (haystack: string, needles: ReadonlyArray<string>): boolean =>
+const hasAny = (haystack: string, needles: ReadonlyArray<string>): boolean =>
   needles.some((needle) => haystack.includes(needle))
 
 const isCliMissingExitCode = (exitCode: number): boolean => exitCode === 127
@@ -44,15 +44,15 @@ const daemonDownMarkers: ReadonlyArray<string> = [
 export const classifyDockerProbeFailure = (outcome: DockerProbeOutcome): DockerProbeFailureKind => {
   const normalized = lowercase(outcome.stderr)
 
-  if (containsAny(normalized, permissionMarkers)) {
+  if (hasAny(normalized, permissionMarkers)) {
     return "socket-permission-denied"
   }
 
-  if (isCliMissingExitCode(outcome.exitCode) && containsAny(normalized, cliMissingMarkers)) {
+  if (isCliMissingExitCode(outcome.exitCode) && hasAny(normalized, cliMissingMarkers)) {
     return "docker-cli-missing"
   }
 
-  if (containsAny(normalized, daemonDownMarkers)) {
+  if (hasAny(normalized, daemonDownMarkers)) {
     return "daemon-unreachable"
   }
 

packages/app/src/docker-git/controller-docker.ts

@@ -107,17 +107,14 @@ export const resolveDockerCommand = (): Effect.Effect<
     }
 
     const dockerHostRaw = process.env["DOCKER_HOST"]?.trim() ?? ""
+    const accessDeniedMessage = renderDockerAccessDeniedMessage({
+      directProbe,
+      sudoProbe,
+      apiBaseUrl: resolveConfiguredApiBaseUrl(),
+      dockerHost: dockerHostRaw.length > 0 ? dockerHostRaw : null
+    })
     return yield* _(
-      Effect.fail(
-        controllerBootstrapError(
-          renderDockerAccessDeniedMessage({
-            directProbe,
-            sudoProbe,
-            apiBaseUrl: resolveConfiguredApiBaseUrl(),
-            dockerHost: dockerHostRaw.length > 0 ? dockerHostRaw : null
-          })
-        )
-      )
+      Effect.fail(controllerBootstrapError(accessDeniedMessage))
     )
   })
 
@@ -256,7 +253,7 @@ const mapDockerCaptureError =
 // QUOTE(ТЗ): "комментарии ребита надо было тоже поддержать"
 // REF: CodeRabbit PR #344 review 4349265315
 // SOURCE: n/a
-// FORMAT THEOREM: includeOutput -> failure_with_output; !includeOutput -> base_failure
+// FORMAT THEOREM: shouldIncludeOutput -> failure_with_output; !shouldIncludeOutput -> base_failure
 // PURITY: CORE
 // EFFECT: n/a
 // INVARIANT: both modes preserve headline, command and exit code
@@ -268,14 +265,14 @@ const mapDockerCaptureError =
  * @param invocation - Resolved Docker invocation.
  * @param exitCode - Process exit code.
  * @param output - Combined stdout/stderr from the process.
- * @param includeOutput - Whether the message should include captured process output.
+ * @param shouldIncludeOutput - Whether the message should include captured process output.
  * @returns Stable Docker failure message.
  *
  * @pure true
  * @effect n/a
  * @invariant Base diagnostics always include command and exit code.
  * @precondition `exitCode` is the observed process exit code.
- * @postcondition Captured output appears only when `includeOutput` is true and output is non-empty.
+ * @postcondition Captured output appears only when `shouldIncludeOutput` is true and output is non-empty.
  * @complexity O(n) where n = |output|.
  * @throws Never
  */
@@ -284,9 +281,9 @@ const formatDockerCaptureFailure = (
   invocation: DockerInvocation,
   exitCode: number,
   output: string,
-  includeOutput: boolean
+  shouldIncludeOutput: boolean
 ): string =>
-  includeOutput
+  shouldIncludeOutput
     ? formatDockerInvocationFailureWithOutput(`${label} failed.`, invocation, exitCode, output)
     : formatDockerInvocationFailure(`${label} failed.`, invocation, exitCode)
 
@@ -305,7 +302,7 @@ const formatDockerCaptureFailure = (
  *
  * @param args - Docker CLI arguments after the executable.
  * @param label - Operation label used in diagnostics.
- * @param includeOutput - Whether non-zero exit diagnostics include captured stdout/stderr.
+ * @param shouldIncludeOutput - Whether non-zero exit diagnostics include captured stdout/stderr.
  * @returns Effect containing stdout on success.
  *
  * @pure false
@@ -319,7 +316,7 @@ const formatDockerCaptureFailure = (
 const runDockerCaptureWithOutputMode = (
   args: ReadonlyArray<string>,
   label: string,
-  includeOutput: boolean
+  shouldIncludeOutput: boolean
 ): Effect.Effect<string, ControllerBootstrapError, ControllerRuntime> =>
   resolveDockerInvocation(args).pipe(
     Effect.flatMap((invocation) =>
@@ -331,7 +328,7 @@ const runDockerCaptureWithOutputMode = (
         },
         [0],
         (exitCode, output) =>
-          controllerBootstrapError(formatDockerCaptureFailure(label, invocation, exitCode, output, includeOutput))
+          controllerBootstrapError(formatDockerCaptureFailure(label, invocation, exitCode, output, shouldIncludeOutput))
       )
     ),
     Effect.mapError(mapDockerCaptureError(label))
@@ -379,10 +376,11 @@ export const runCompose = (
 ): Effect.Effect<void, ControllerBootstrapError, ControllerRuntime> =>
   Effect.gen(function*(_) {
     const dockerCommand = yield* _(resolveDockerCommand())
+    const composeFiles = yield* _(ControllerCompose.resolveControllerComposeFiles())
     const invocation = buildDockerInvocation(dockerCommand, [
       "compose",
       ...ControllerCompose.controllerComposeProjectArgs,
-      ...ControllerCompose.composeFilesToArgs(yield* _(ControllerCompose.resolveControllerComposeFiles())),
+      ...ControllerCompose.composeFilesToArgs(composeFiles),
       ...args
     ])
     const exitCode = yield* _(
@@ -402,12 +400,13 @@ export const runCompose = (
       return
     }
 
+    const failureMessage = formatDockerInvocationFailure(
+      "Failed to start docker-git controller.",
+      invocation,
+      exitCode
+    )
     return yield* _(
-      Effect.fail(
-        controllerBootstrapError(
-          formatDockerInvocationFailure("Failed to start docker-git controller.", invocation, exitCode)
-        )
-      )
+      Effect.fail(controllerBootstrapError(failureMessage))
     )
   })