refactor(container): drop unrelated lint auto-fixes and redundant prelint:effect (#412)

Self-review cleanup:

- Revert 15 files that an earlier `git add -A` swept in from the
  vibecode-linter's auto-fix (String.raw->string, readonly T[]->ReadonlyArray,
  line-wrapping, .split("/",1)). All were behaviour-preserving but unrelated to
  the container extraction; restoring them keeps this PR scoped to #412 and
  preserves blame.
- Remove lib's `prelint:effect`: `lint:effect` is plain ESLint and resolves
  fine without the built container .d.ts (it passed in CI without it), so
  building the container before it was redundant. `prelint` (for the
  tsc-running `lint`) stays.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

Author: skulidropek

packages/app/src/docker-git/api-terminal-codec.ts

@@ -17,7 +17,8 @@ type RawTerminalSession = {
 
 const isTerminalSessionStatus = (
   value: string
-): value is ApiTerminalSession["status"] => ["ready", "attached", "exited", "failed"].includes(value)
+): value is ApiTerminalSession["status"] =>
+  ["ready", "attached", "exited", "failed"].includes(value)
 
 const readOptionalNumber = (value: JsonValue | undefined): number | undefined =>
   typeof value === "number" ? value : undefined

packages/app/src/docker-git/controller-docker.ts

@@ -37,7 +37,7 @@ export const controllerContainerName = process.env["DOCKER_GIT_API_CONTAINER_NAM
 
 const inspectNetworksTemplate = String
   .raw`{{range $k,$v := .NetworkSettings.Networks}}{{printf "%s=%s\n" $k $v.IPAddress}}{{end}}`
-const inspectEnvTemplate = "{{range .Config.Env}}{{println .}}{{end}}"
+const inspectEnvTemplate = String.raw`{{range .Config.Env}}{{println .}}{{end}}`
 
 const controllerBootstrapError = (message: string): ControllerBootstrapError => ({
   _tag: "ControllerBootstrapError",

packages/app/src/docker-git/controller-image-revision.ts

@@ -9,8 +9,8 @@ import { type ControllerRuntime, runDockerCapture, runDockerCaptureWithFailureOu
 import { parseControllerRevisionLabelOutput } from "./controller-revision.js"
 import type { ControllerBootstrapError } from "./host-errors.js"
 
-const inspectControllerRevisionLabelTemplate =
-  "{{ index .Config.Labels \"io.prover-coder-ai.docker-git.controller-rev\" }}"
+const inspectControllerRevisionLabelTemplate = String
+  .raw`{{ index .Config.Labels "io.prover-coder-ai.docker-git.controller-rev" }}`
 const missingImageInspectionPatterns: ReadonlyArray<RegExp> = [/No such image/iu, /No such object/iu]
 
 /**

packages/app/src/docker-git/frontend-lib/core/auto-agent-flags.ts

@@ -14,7 +14,7 @@ export const resolveAutoAgentFlags = (
   if (requested === "auto") {
     return Either.right({ agentMode: undefined, agentAuto: true })
   }
-  const agentModes: ReadonlyArray<AgentMode> = ["claude", "codex", "gemini", "grok"]
+  const agentModes: readonly AgentMode[] = ["claude", "codex", "gemini", "grok"]
   const matchedMode = agentModes.find((mode) => mode === requested)
   if (matchedMode !== undefined) {
     return Either.right({ agentMode: matchedMode, agentAuto: true })

packages/app/src/docker-git/host-errors.ts

@@ -56,14 +56,7 @@ export type HostError =
 export type CliError = ParseError | HostError
 
 const isParseError = (error: CliError): error is ParseError =>
-  [
-    "UnknownCommand",
-    "UnknownOption",
-    "MissingOptionValue",
-    "MissingRequiredOption",
-    "InvalidOption",
-    "UnexpectedArgument"
-  ].includes(error._tag)
+  ["UnknownCommand", "UnknownOption", "MissingOptionValue", "MissingRequiredOption", "InvalidOption", "UnexpectedArgument"].includes(error._tag)
 
 const renderApiRequestError = (error: ApiRequestError): string =>
   error.displayOnlyMessage === true

packages/app/src/docker-git/menu-auth.ts

@@ -99,9 +99,7 @@ const submitAuthPrompt = (view: AuthPromptView, context: AuthInputContext) => {
       const label = defaultLabel(nextValues["label"] ?? "")
       const effect = resolveAuthPromptEffect(view, context.state.cwd, nextValues)
       runAuthPromptEffect(effect, view, label, { ...context, cwd: context.state.cwd }, {
-        suspendTui: ["GithubOauth", "CodexOauth", "ClaudeOauth", "ClaudeLogout", "GeminiOauth", "GrokOauth"].includes(
-          view.flow
-        )
+        suspendTui: ["GithubOauth", "CodexOauth", "ClaudeOauth", "ClaudeLogout", "GeminiOauth", "GrokOauth"].includes(view.flow)
       })
     }
   )

packages/app/src/docker-git/menu-project-auth.ts

@@ -130,13 +130,7 @@ const runProjectAuthAction = (
   }
 
   if (
-    [
-      "ProjectGithubDisconnect",
-      "ProjectGitDisconnect",
-      "ProjectClaudeDisconnect",
-      "ProjectGeminiDisconnect",
-      "ProjectGrokDisconnect"
-    ].includes(action)
+    ["ProjectGithubDisconnect", "ProjectGitDisconnect", "ProjectClaudeDisconnect", "ProjectGeminiDisconnect", "ProjectGrokDisconnect"].includes(action)
   ) {
     runProjectAuthEffect(view.project, action, {}, "default", context)
     return

packages/app/src/docker-git/menu-select-presenter.ts

@@ -44,7 +44,7 @@ const formatRepoRef = (repoRef: string): string => {
   const prPrefix = "refs/pull/"
   if (trimmed.startsWith(prPrefix)) {
     const rest = trimmed.slice(prPrefix.length)
-    const number = rest.split("/", 1)[0] ?? rest
+    const number = rest.split("/")[0] ?? rest
     return `PR#${number}`
   }
   return trimmed.length > 0 ? trimmed : "main"

packages/app/src/web/app-ready-ssh-link-core.ts

@@ -28,7 +28,7 @@ const decodePathTail = (value: string): string | null => {
 }
 
 const readSessionPathRequest = (tail: string): SshLinkRequest | null => {
-  const decoded = safeDecodeURIComponent(tail.slice("session/".length).split("/", 1)[0] ?? "")
+  const decoded = safeDecodeURIComponent(tail.slice("session/".length).split("/")[0] ?? "")
   const sessionId = decoded?.trim() ?? ""
   return sessionId.length === 0 ? null : { kind: "session", sessionId }
 }

packages/app/src/web/app-terminal-session-core.ts

@@ -10,7 +10,7 @@ export const readTerminalSessionRoute = (pathname: string): string | null => {
     return null
   }
 
-  const rawSessionId = pathname.slice(terminalSessionRoutePrefix.length).split("/", 1)[0] ?? ""
+  const rawSessionId = pathname.slice(terminalSessionRoutePrefix.length).split("/")[0] ?? ""
   const sessionId = decodeURIComponent(rawSessionId).trim()
   return sessionId.length === 0 ? null : sessionId
 }