Skip to content

Commit 9343327

Browse files
authored
Merge pull request #38 from Project-OMOTES/change-result-error-handling
removed error handling from result handler
2 parents a31137b + ea84b7c commit 9343327

2 files changed

Lines changed: 11 additions & 8 deletions

File tree

sdk/src/lib/handlers/ResultHandler.spec.ts

Lines changed: 11 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -44,12 +44,18 @@ describe('ResultsHandler', () => {
4444

4545
it('should error when not succeeded', (done) => {
4646
handler.getResult().subscribe({
47-
next: () => {
48-
done.fail('Should not have succeeded');
47+
next: (result) => {
48+
expect(result).toEqual({
49+
uuid: 'uuid',
50+
logs: 'logs',
51+
outputEsdl: '',
52+
resultType: JobResult.ResultType.ERROR,
53+
esdlMessagesList: [],
54+
});
55+
done()
4956
},
50-
error: (error) => {
51-
expect(error.message).toEqual('Job uuid failed: logs');
52-
done();
57+
error: () => {
58+
done.fail('should not have thrown error')
5359
},
5460
complete: () => {
5561
done.fail('Should not have completed');

sdk/src/lib/handlers/ResultHandler.ts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,6 @@ export class ResultHandler extends JobHandler {
1111
return messages$.pipe(
1212
map((message) => {
1313
const result = JobResult.deserializeBinary(message.content);
14-
if (result.getResultType() === JobResult.ResultType.ERROR) {
15-
throw new Error(`Job ${result.getUuid()} failed: ${result.getLogs()}`);
16-
}
1714
return result.toObject();
1815
})
1916
);

0 commit comments

Comments
 (0)