Feedback sprint 6

[lkrombeen]

sprint planning:

• If you plan on making adjustments for the next sprint, make sure to execute them as well.
• Most issues have no description.
• Assign a single responsible team member to your issues who makes sure the task gets done.
• You should split some tasks into more smaller tasks. For example, Zooming remastered #77.
• In your current situation you need to adjust some priorities. Bookmarks #85 should have been done already. Maybe you mean something else with Bookmarks. In that case, make your issues less ambiguous.
• There are some builds that are failing and some are take a couple of commits before they are fixed.
• I noticed that you made 1 commit to master which was the main.jar. A pull request would have been better where someone could check if the .jar also works on his machine. Do not forget to include it to the release so Jasper can find it next time.
• You should not merge a PR just because it has to be merged e.g. Zoom enhance #74.
• Make user stories and link back to them from your issues.
• Tasks are not split evenly. Dexter is doing almost twice as much as the rest.

code evaluation

• I cannot do anything with your code due to “Missing artifact com.sun:tools:jar:1.8.0”. What am I required to install?
• Still many complex methods and classes. Same issues from last weeks feedback. NodeGraph is very problematic.
• Do not use == when comparing floats. Equality tests should not be made with floating point values, because they do not work properly for -0 and NaN.
• There are unused variables e.g. ind2.
• Check for null when using nullables.
• There are unused methods in GraphScene.
• No duplicate code, good.
• I get 36.4% test coverage, but I was unable to run Cobertura so can be slightly off.
• Comments are fine, but the complex methods are hard to interpret. Split them and document them better.